-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] CLI add command (add-api, add-consumer) #147
Conversation
3606195
to
2c08728
Compare
@thefosk thoughts? @nijikokun do you see this being simpler for the docs? |
so this starts an instance and executes, does it also check if an instance is already running? |
It does not start any instance, just expects cassandra to be running. |
Then why the configuration output? I guess it is to tell you which instance its being done to? |
Because it's mandatory like any Kong command, it needs the configuration, in this case for the cassandra properties. |
Hmm, seems a bit verbose, but alright. Output could be a little bit better, on multiple lines for the data so its easier to read, and spot potential mistakes. I think it would also require Something I was thinking of was |
We don't need to deal with the API so let's not bother. I think update is overkill, remove why not. |
It's only verbose because I'm using the utils method to retrieve a configuration, and it outputs logs when it runs, only to inform the user like the other commands. If it's verbose here, it might be in other commands too. |
7dbb819
to
ee352b0
Compare
8a197fe
to
8f3e970
Compare
@@ -5,5 +5,5 @@ source ./versions.sh | |||
CASSANDRA_BASE=apache-cassandra-$CASSANDRA_VERSION | |||
|
|||
sudo rm -rf /var/lib/cassandra/* | |||
curl http://www.us.apache.org/dist/cassandra/$CASSANDRA_VERSION/$CASSANDRA_BASE-bin.tar.gz | tar xz | |||
curl http://apache.spinellicreations.com/cassandra/$CASSANDRA_VERSION/$CASSANDRA_BASE-bin.tar.gz | tar xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's a good idea to use none official sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is official, it is a mirror on the official download page. This change shouldn't be here anyways, oops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I just saw the domain and it looks like some guy's personal site ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What actually happened is that some day, all of a sudden, version 2.1.{3 I think} just disappeared from the main repo, without any notice... I used this mirror which still had it but after a while it disappeared too. Turns out we don't have a choice but to update to 2.1.{4,5}, which we did already in master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah-mazing!
3306b8a
to
4ae27e5
Compare
4ae27e5
to
a61a146
Compare
Added a ready label because as discussed with @sinzone, this is ready to be merged anytime as is. more can be added to it later. |
a61a146
to
d2ebdc9
Compare
@thibaultcha remember to merge this before 0.4 |
d2ebdc9
to
0df5b38
Compare
That's not as easily doable as before because the CLI arguments parsing expects one letter args names (-n for --name) but now that an API can have a public_dns and a path, we can't have two |
### Summary > Released on: 2022/05/20 #### Fixed - Improve DC-aware LB policies robustness. [#147](thibaultcha/lua-cassandra#147) - Ensure request-aware + DC-aware LB policy prioritizes local peers over remote ones.
### Summary > Released on: 2022/05/20 #### Fixed - Improve DC-aware LB policies robustness. [#147](thibaultcha/lua-cassandra#147) - Ensure request-aware + DC-aware LB policy prioritizes local peers over remote ones.
Part of improvements needed for the CLI described in #92. Sugar method of adding APIs and Consumers to Kong:
What could be improved:
--username='jason'
for example.