Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APL][SSP] UP2 with PCM512x: kernel errors #3061

Closed
lyakh opened this issue Jul 23, 2021 · 11 comments
Closed

[APL][SSP] UP2 with PCM512x: kernel errors #3061

lyakh opened this issue Jul 23, 2021 · 11 comments
Labels
APL Applies to ApolloLake platform bug Something isn't working topology Issues caused by topology

Comments

@lyakh
Copy link
Collaborator

lyakh commented Jul 23, 2021

I'm routinely getting the following kernel errors on my UP2 with PCM512x:

SSP5-Codec: ASoC: no backend capture stream

and

SSP5-Codec: ASoC: no users capture at close - state 0

Sometimes I'm also getting firmware boot failures:

[ 2222.114879] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: FW Poll Status: reg[0x4c]=0x40000000 successful
[ 2222.114890] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: FW Poll Status: reg[0x4]=0x3030202 successful
[ 2222.115157] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: FW Poll Status: reg[0x4]=0x1010202 successful
[ 2222.115163] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: DSP core(s) enabled? 0 : core_mask 2
[ 2222.131106] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: FW Poll Status: reg[0x80000]=0x5000001 successful
[ 2223.798272] [1910]  SSP5-Codec: ASoC: pop wq checking: Playback status: inactive waiting: yes
[ 2223.798342] [1910]  Media Playback 4: ASoC: pop wq checking: Playback status: inactive waiting: yes
[ 2225.131747] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: FW Poll Status: reg[0x80000]=0x81000012 timedout
[ 2225.131764] sof-audio-pci-intel-apl 0000:00:0e.0: error: cl_copy_fw: timeout HDA_DSP_SRAM_REG_ROM_STATUS read
[ 2225.131780] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: FW Poll Status: reg[0x160]=0x140000 successful
[ 2225.131789] sof-audio-pci-intel-apl 0000:00:0e.0: ------------[ DSP dump start ]------------
[ 2225.131798] [4823] sof-audio-pci-intel-apl 0000:00:0e.0: unknown ROM status value 81000012
[ 2225.131815] sof-audio-pci-intel-apl 0000:00:0e.0: error: extended rom status:  0x81000012 0xecc00302 0x0 0x0 0x0 0x0 0x1522101 0x0
[ 2225.131822] sof-audio-pci-intel-apl 0000:00:0e.0: ------------[ DSP dump end ]------------
[ 2225.131827] sof-audio-pci-intel-apl 0000:00:0e.0: error: load fw failed ret: -110
[ 2225.131873] sof-audio-pci-intel-apl 0000:00:0e.0: error: failed to start DSP
[ 2225.131879] sof-audio-pci-intel-apl 0000:00:0e.0: error: failed to boot DSP firmware after resume -110
[ 2225.131891] sof-audio-pci-intel-apl 0000:00:0e.0: ASoC: error at snd_soc_pcm_component_pm_runtime_get on 0000:00:0e.0: -110

which made me wonder whether that boot failure is related to the pop work? IIUC @lgirdwood suggested that the SSP5 errors are caused by errors in topology, and that the boot failure is probably unrelated to that.
@lyakh lyakh added bug Something isn't working APL Applies to ApolloLake platform topology Issues caused by topology labels Jul 23, 2021
@plbossart
Copy link
Member

@lyakh I can reproduce the 'ASoC' errors, sof-test flags an error on every capture.

So far no boot issues though. Can you confirm this happens with a bog-standard SOF configuration?

@plbossart
Copy link
Member

the DAPM map is all over the place.
widgets

We should use simpler topologies...

@lyakh
Copy link
Collaborator Author

lyakh commented Jul 23, 2021

@plbossart no, sorry for not mentioning, the boot error I've only seen with Zephyr so far. But since it's sporadic, and happens before the firmware is actually executed, IIUC, and I always reboot to reload firmware, it seems to me, that it shouldn't be Zephyr-related.

@plbossart
Copy link
Member

@lyakh could still be due to power-down differences between xtos and Zephyr, no?

@lyakh
Copy link
Collaborator Author

lyakh commented Jul 23, 2021

@plbossart sorry, indeed, you're right. I thought I had cases where it failed the first firmware run, but I just double-checked, and yes, it's always one of follow-up boots after a D3. So, yes, it's possible.

@plbossart
Copy link
Member

@lyakh it's a disconnect between topology and machine driver.

The topology exposes a capture path on PCM5.

The machine driver does not set dpcm_capture=1 for the dailink. it's explicited commented out. We haven't changed the code since 2020.

Ironically this points to an SOF commit

ea8055d topology: APL: add an SSP5 capture pipeline

This never worked...

plbossart added a commit to plbossart/sound that referenced this issue Jul 23, 2021
@plbossart
ASoC: Intel: update sof_pcm512x quirks
72718ed 
The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
@plbossart plbossart mentioned this issue Jul 23, 2021
Merged
@plbossart
Copy link
Member

@lyakh PR #3092 fixes the ASoC issues. You should file the boot issues in a separate entry, this has nothing to do with topology, agree with @lgirdwood

@lyakh
Copy link
Collaborator Author

lyakh commented Jul 23, 2021

@lyakh it's a disconnect between topology and machine driver.

The topology exposes a capture path on PCM5.

The machine driver does not set dpcm_capture=1 for the dailink. it's explicited commented out. We haven't changed the code since 2020.

Ironically this points to an SOF commit

ea8055d topology: APL: add an SSP5 capture pipeline

This never worked...

@plbossart Thanks for the investigation and a fix! Although I must disagree - I'm pretty sure it did work. I'm testing DMICs regularly enough on the hardware, and I'm sure I connected my phone headphone output to HiFiBerry input and captured audio multiple times too. This latter test I haven't done in a while, but I still have a cable plugged in into the 3.5mm line-in port of that card. Or have I misunderstood your "never worked" phrase?

@plbossart
Copy link
Member

I stand by my comment @lyakh: the machine driver never had capture support but the topology did. It must have worked with the machine driver explicitly enabling the capture in your local setup, but not with a clean git reset --hard; git pull

@lyakh
Copy link
Collaborator Author

lyakh commented Jul 26, 2021 •
edited
Loading

I stand by my comment @lyakh: the machine driver never had capture support but the topology did. It must have worked with the machine driver explicitly enabling the capture in your local setup, but not with a clean git reset --hard; git pull

@plbossart I don't know what miracle is driving this, but I've just re-tested my UP2 with a DMIC attachment board and with no kernel modifications and I was able to record audio (and to play it back). EDIT: line-in on the HiFiBerry worked too.

plbossart added a commit that referenced this issue Jul 30, 2021
@plbossart
ASoC: Intel: update sof_pcm512x quirks
405243f 
The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: #3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart added a commit that referenced this issue Aug 2, 2021
@plbossart
ASoC: Intel: update sof_pcm512x quirks
849a898 
The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: #3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Aug 2, 2021
@plbossart @intel-lab-lkp
ASoC: Intel: update sof_pcm512x quirks
52958bd 
The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
morimoto pushed a commit to morimoto/linux that referenced this issue Aug 4, 2021
@plbossart @broonie
ASoC: Intel: update sof_pcm512x quirks
22414ca 
The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
plbossart added a commit that referenced this issue Aug 12, 2021
@plbossart
ASoC: Intel: update sof_pcm512x quirks
27072b3 
The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: #3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
@lyakh
Copy link
Collaborator Author

lyakh commented Sep 6, 2021

@plbossart can this be closed now?

woodsts pushed a commit to woodsts/linux-stable that referenced this issue Sep 18, 2021
@plbossart @gregkh
ASoC: Intel: update sof_pcm512x quirks
a64e3f1 
[ Upstream commit 22414ca ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
woodsts pushed a commit to woodsts/linux-stable that referenced this issue Sep 18, 2021
@plbossart @gregkh
ASoC: Intel: update sof_pcm512x quirks
f38dd8e 
[ Upstream commit 22414ca ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
woodsts pushed a commit to woodsts/linux-stable that referenced this issue Sep 18, 2021
@plbossart @gregkh
ASoC: Intel: update sof_pcm512x quirks
cd86be4 
[ Upstream commit 22414ca ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
gibsson pushed a commit to boundarydevices/linux that referenced this issue Oct 18, 2021
@plbossart @gibsson
ASoC: Intel: update sof_pcm512x quirks
ee4c275 
[ Upstream commit 22414ca ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
it-is-a-robot pushed a commit to openeuler-mirror/kernel that referenced this issue Oct 22, 2021
@plbossart @Zhengzengkai
ASoC: Intel: update sof_pcm512x quirks
dca1b3d 
stable inclusion
from stable-5.10.67
commit a64e3f1d8a27f6868e01f99f7f21519e46da61fb
bugzilla: 182619 https://gitee.com/openeuler/kernel/issues/I4EWO7

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a64e3f1d8a27f6868e01f99f7f21519e46da61fb

--------------------------------

[ Upstream commit 22414ca ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Chen Jun <[email protected]>
Acked-by: Weilong Chen <[email protected]>

Signed-off-by: Chen Jun <[email protected]>
Signed-off-by: Zheng Zengkai <[email protected]>
vinzv pushed a commit to tuxedocomputers/linux that referenced this issue Nov 11, 2021
@plbossart @smb49
ASoC: Intel: update sof_pcm512x quirks
465b281 
BugLink: https://bugs.launchpad.net/bugs/1947781

[ Upstream commit 22414ca ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Kamal Mostafa <[email protected]>
Signed-off-by: Kelsey Skunberg <[email protected]>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Nov 21, 2021
@plbossart
ASoC: Intel: update sof_pcm512x quirks
132dd8e 
[ Upstream commit 22414ca ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Rohail33 pushed a commit to Rohail33/Realking_xiaomi_xaga that referenced this issue Dec 31, 2022
@plbossart @Rohail33
ASoC: Intel: update sof_pcm512x quirks
8c9b26e 
[ Upstream commit 22414cade8dfec25ab94df52b3a4f7aa8edb6120 ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Gabriel2392 pushed a commit to Gabriel2392/android_kernel_samsung_a33x that referenced this issue Feb 19, 2023
@plbossart @Gabriel2392
ASoC: Intel: update sof_pcm512x quirks
356ee59 
[ Upstream commit 22414cade8dfec25ab94df52b3a4f7aa8edb6120 ]

The default SOF topology enables SSP capture and DMICs, even though
both of these hardware capabilities are not always available in
hardware (specific versions of HiFiberry and DMIC kit needed).

For the SSP capture, this leads to annoying "SP5-Codec: ASoC: no
backend capture" and "streamSSP5-Codec: ASoC: no users capture at
close - state 0" errors.

Update the quirks to match what the topology needs, which also allows
for the ability to remove SSP capture and DMIC support.

BugLink: thesofproject/linux#3061
Signed-off-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Guennadi Liakhovetski <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
APL Applies to ApolloLake platform bug Something isn't working topology Issues caused by topology
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plbossart @lyakh