Make Intel IPC stream ops generic #3092
Conversation
Potochi
requested review from
bardliao,
dbaluta,
juimonen,
keyonjie,
kv2019i,
lgirdwood,
libinyang,
lyakh,
plbossart,
RanderWang and
ranj063
as code owners
Potochi
force-pushed
the
generic_ipc
branch
3 times, most recently
from
6a5a311 to
eff0d2f
Compare
There was a problem hiding this comment.
ARM compilation failure?
CC [M] sound/soc/fsl/fsl-asoc-card.o
sound/soc/sof/imx/imx8.c:388:12: error: ‘imx8_ipc_pcm_params’ defined but not used [-Werror=unused-function]
388 | static int imx8_ipc_pcm_params(struct snd_sof_dev *sdev,
| ^~~~~~~~~~~~~~~~~~~
sound/soc/sof/imx/imx8.c:380:12: error: ‘imx8_ipc_msg_data’ defined but not used [-Werror=unused-function]
380 | static int imx8_ipc_msg_data(struct snd_sof_dev *sdev,
| ^~~~~~~~~~~~~~~~~
|
@Potochi can you have a look. Why this didn't fail on our tests? Can you check the .config file? |
Potochi
force-pushed
the
generic_ipc
branch
2 times, most recently
from
c60b59f to
2888f0f
Compare
sound/soc/sof/core.c
Outdated
| @@ -310,6 +310,7 @@ int snd_sof_device_probe(struct device *dev, struct snd_sof_pdata *plat_data) | |||
| /* check all mandatory ops */ | |||
| if (!sof_ops(sdev) || !sof_ops(sdev)->probe || !sof_ops(sdev)->run || | |||
| !sof_ops(sdev)->block_read || !sof_ops(sdev)->block_write || | |||
| !sof_ops(sdev)->mailbox_read || !sof_ops(sdev)->mailbox_write || | |||
There was a problem hiding this comment.
AMD platform is not using mmaped IO for IPC so make it an optional ops() callback and not a mandatory one.
There was a problem hiding this comment.
Not following @ajitkupandey. This patch precisely enables you to not use mmap IO but the mechanism of your choice.
There was a problem hiding this comment.
yeah i saw we can implement our custom mailbox_read()/write() but we aren't using mailbox read and write at the moment. If we make it mandatory we will be forced to implement such callbacks as directly sof_mailbox_read() not going to work for us so we prefer to make it an optional dsp ops () callback for now.
There was a problem hiding this comment.
@ajitkupandey OK. I think for now we can make this ops optional.
There was a problem hiding this comment.
@dbaluta @plbossart Thanks.. FYI we will implement custom mailbox_read()/write() for AMD platform to make our code more streamline with SOF core but for now keeping these ops optional is really helpful.
…lbacks
We need to introduce snd_sof_mailbox_{read/write} in order to provide
a generic way for mailbox access. These routines are optional, each
platform can implement their own specific routines.
So far, all platforms use mmaped I/O thus they can use custom made
routines sof_mailbox_read / sof_mailbox_write that use MMIO.
Signed-off-by: Daniel Baluta <[email protected]>
Signed-off-by: Bud Liviu-Alexandru <[email protected]>
This operations should be generic as there is nothing Intel specific. This works well for NXP i.MX8 stream IPC ops. We start by moving sof/intel/intel-ipc.c into sof/stream-ipc.c and rename the functions to be generic. Notice that we use newly introduced snd_sof_dsp_mailbox_read instead of sof_mailbox_read, to make sure that we are not bound to existing MMIO memory access, and we allow platform to implement their own memory access routines. Signed-off-by: Daniel Baluta <[email protected]> Signed-off-by: Bud Liviu-Alexandru <[email protected]>
This makes IMX use the newly introduced generic IPC ops instead of imx specific ones, and removes the old IMX ipc ops, as they are no longer needed. Signed-off-by: Daniel Baluta <[email protected]> Signed-off-by: Bud Liviu-Alexandru <[email protected]>
Operations implemented in sof/intel/intel-ipc.c should be generic and are of a good use to IMX also. So, make them generic.
This is a rebase of #2914.