Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt, scripted-plugin to 1.4.3 #198

Closed
wants to merge 3 commits into from
Closed

Update sbt, scripted-plugin to 1.4.3 #198

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba398ae
Update sbt, scripted-plugin to 1.4.3
scala-steward Nov 16, 2020
61b126a
Merge branch 'master' into update/sbt-1.4.3
scala-steward Nov 16, 2020
b8cc501
Update sbt, scripted-plugin to 1.4.3
scala-steward Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# also update .github/workflows/ci.yml to ensure compatibility of the plugin via scripted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this note should be taken into account and .github/workflows/ci.yml bumped manually, as I was trying to explain in #196 (comment)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh - forgot! Perhaps we should disable Scala steward updates for sbt.

Copy link
Contributor

@bjaglin bjaglin Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe just mergify if that's possible? I thought about it and it should be possible not to duplicate the value there by setting a separate setting in .github/workflows/ci.yml, which would set scriptedSbt only if the value if not a magic value latest. I'll open a PR to try that out.

sbt.version=1.4.2
sbt.version=1.4.3