-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sbt, scripted-plugin to 1.4.3 #198
Conversation
@bjaglin - it looks like there's binary compatibility issue with older SBT versions. It would be great if you will you be able to look into this. |
@thesamet looks like a regression caused by sbt/sbt#6054 with the new default |
project/build.properties
Outdated
@@ -1,2 +1,2 @@ | |||
# also update .github/workflows/ci.yml to ensure compatibility of the plugin via scripted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this note should be taken into account and .github/workflows/ci.yml
bumped manually, as I was trying to explain in #196 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh - forgot! Perhaps we should disable Scala steward updates for sbt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe just mergify if that's possible? I thought about it and it should be possible not to duplicate the value there by setting a separate setting in .github/workflows/ci.yml
, which would set scriptedSbt
only if the value if not a magic value latest
. I'll open a PR to try that out.
@bjaglin thanks for looking into this! |
Updates
from 1.4.2 to 1.4.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
Ignore future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:labels: library-update, semver-patch