fix(footer>theme.ts): adding margin to right in footer links #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is table for firstpage var fix The page number was not showing correctly on firsrt few clicks because lastPage variable was not updating on first few clicks when layout is table due to incorrect addition. Was working correctly when layout is pagination. fix themesberg#1150
The link elements were not responsive because there was no default margin set. me-4 was added to non-react footer but not in react footer. themesberg#1085
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 99.54% 93.60% -5.95%
==========================================
Files 163 213 +50
Lines 6621 9049 +2428
Branches 401 484 +83
==========================================
+ Hits 6591 8470 +1879
- Misses 30 579 +549 ☔ View full report in Codecov by Sentry. |
|
@rajatpandey441 looks good, just make sure to remove the last "merge" and instead use rebase to keep the git history on track. :) |
|
@rluders: Let me make a new branch with relevant commit and close this Pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
The link elements were not responsive because there was no default margin set. me-4 was added to
non-react footer but not in react footer.
Reference related issues using
#followed by the issue number.#1085
If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.
NA
Screenshots
Non-React
React
