Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: pagination component issue on documentation page #1150

Closed
2 tasks done
jonny-ibdr opened this issue Nov 25, 2023 · 3 comments · Fixed by #1151 or #1325
Closed
2 tasks done

Docs: pagination component issue on documentation page #1150

jonny-ibdr opened this issue Nov 25, 2023 · 3 comments · Fixed by #1151 or #1325
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers

Comments

@jonny-ibdr
Copy link

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Steps to reproduce

  1. Go to this page.
  2. Click on the 'Next' button
  3. Notice how the page ranges stay the same

Current behavior

Recording.2023-11-25.185939.mp4

Expected behavior

It should go to the next page range (2 to 6)

Context

Video is recorded using Microsoft Edge, but assuming it wont matter
@rluders rluders added 🐛 bug Something isn't working good first issue Good for newcomers confirmed This bug was confirmed labels Nov 25, 2023
@rajatpandey441
Copy link
Contributor

Hey. Can I work on this issue?

@rluders
Copy link
Collaborator

rluders commented Nov 26, 2023

@rajatpandey441 don't need to ask, just go ahead and create the PR. :)

rajatpandey441 added a commit to rajatpandey441/flowbite-react that referenced this issue Nov 26, 2023
@rajatpandey441
fix(pagination): updating lastPage variable to currPage+4 when layout…
2db498e 
… is table for firstpage var fix

The page number was not showing correctly on firsrt few clicks because lastPage variable was not
updating on first few clicks when layout is table due to incorrect	addition. Was working correctly
when layout is pagination.

fix themesberg#1150
@rajatpandey441 rajatpandey441 mentioned this issue Nov 26, 2023
Merged
1 task
@rajatpandey441
Copy link
Contributor

rajatpandey441 commented Nov 26, 2023 •
edited
Loading

React.Pagination.-.Flowbite.-.Google.Chrome.2023-11-26.11-19-20.mp4

@rluders: Please note that functionality is working correctly.

tulup-conner pushed a commit that referenced this issue Nov 26, 2023
@rajatpandey441
fix(pagination): updating lastPage variable correctly for table layout (
2259bf5 
#1151)

fix(pagination): updating lastPage variable to currPage+4 when layout is table for firstpage var fix

The page number was not showing correctly on firsrt few clicks because lastPage variable was not
updating on first few clicks when layout is table due to incorrect	addition. Was working correctly
when layout is pagination.

fix #1150
@github-actions github-actions bot mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@rluders @rajatpandey441 @jonny-ibdr