Fixes #35287 - Create column selector on host index page

[pkoprda]

User should be able to specify what columns wants to see on host index page. This approach using PF4 Selector hopefully can be applied for other index pages in the future.

Depends on #9351

[theforeman-bot]

Issues: #35287

[adamruzicka]

Unless I'm missing something, the filter button does nothing.

Maybe it is just my browser, but the elements on the page look a bit out of place. Do we have a ui mockup for this?

[ofedoren]

Also, there is a conflict now :/

[adamruzicka]

When I try to save my selection, nothing happens and I get this in the browser console. What am I doing wrong?

[ofedoren]

Thanks, @pkoprda, few suggestions inline for now, more to come :)

[pkoprda]

Adding some screenshots:

@MariSvirik any thoughts on this?

[ofedoren]

There are still some problems:

1 - If there is another profile then checkboxes of other columns are selected even though they are not default ones.
2 - For some reason when I don't change selections via selector and reload the page, other columns appear (even though they are not default, see the gif)

[MariSvirik]

@pkoprda I would just copy what we have in PF4. Can I see somewhere this implementation and click through it?

Table

1. First of all, I would go with "Manage filters" copy instead of "Filter columns".
2. The button should be closer to the end of the search bar: 16 px spacing between those two
3. The button should be either a link button (without a box around it) as in the PF4 example or a secondary button.

Modal

1. add a description: e.g. "Select columns to display in the table." Otherwise, I'm not sure what is happening there.
2. The position of the modal should be fixed even when the rows collapse. Otherwise, it's super annoying.
3. Based on your example I can clear out the entire table. We should have some default columns that you can't hide e.g. Name.

[ofedoren]

I still encounter few issues:

• codewise: names of the variables are not so consistent, slows the reading/reviewing. I've added few suggestions, but there is still room for improvements.
• workwise: I guess after one hits Save the API call is asynchronous and it migth be the cause of the issue with old columns being selected after the page reloaded.

I'm going to continue with review tomorrow, I'm sending this just to save the notes :)

[ofedoren]

Thanks, @pkoprda, there are few moments to fix, but otherwise it's almost done. Also, I like the new style more than previous button, so 🍪 for improving this as well :)

[ofedoren]

Thanks, @pkoprda, I think now it's ready. I've added a final fix, nothing much. Let's finally get this in. Thanks for bearing with me this whole time!

[ekohl]

@ofedoren please don't squash commits unless that's really what you want. We generally use the rebase option to merge.