Fixes #35595 - Add content profile to selectable columns #10305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues: #35595 |
adamruzicka
reviewed
Oct 17, 2022
ofedoren
force-pushed
the
feat-35595-add-content-profile
branch
from
14272f3 to
b4b4e52
Compare
|
Thanks, @adamruzicka, it was just a copy-paste typo :( this column can't be sortable. Also, here is a screenshot to make the initial review easier: |
|
Code looks fine, starting to test |
|
@ofedoren what was your hammer command for the table preference columns? |
hammer user table-preference create --name hosts --columns |
chris1984
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
ACK, tested each column and it looks correct. @adamruzicka has all of your concerns been addressed?
adamruzicka
approved these changes
Oct 19, 2022
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Coulmns from
Content Hostspage are added as selectable columns toHostspage.Considerations taken when implementing this change?
Basically it allows to proceed with merging
Content Hostspage intoHostspage.What are the testing steps for this pull request?
Currently, the only way to see the columns is to use
hammer user table-preferencecommand to create a preference forhoststable with certain columns. Core's and newContentprofiles can be used. Until theforeman/foreman#9323 is done, there is no other way to select the whole profile.You can also use theforeman/foreman#9323 to test the feature out as well as provide some feedback while it's still in early stage.