Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove context change in assembly #2542

Closed

Conversation

Lennonka
Copy link
Contributor

In #2492, we didn't realize that changing the context in assemblies will mess up the link anchors.
So this PR undoes that.

Please cherry-pick my commits into:

  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (planned Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • Foreman 3.2/Katello 4.4 on EL7 & EL8
  • Foreman 3.1/Katello 4.3 on EL7 & EL8 (Satellite 6.11 EL7/8; orcharhino 6.3 on EL7/8)
  • We do not accept PRs for Foreman older than 3.1.

@Lennonka Lennonka marked this pull request as draft October 19, 2023 13:48
@github-actions
Copy link

The PR preview for db20338 could not be generated

@maximiliankolb
Copy link
Contributor

I noticed those issues myself when building the docs which is why I changed the context in the assemblies. Does it help to reduce the number of affected modules? I am afraid we cannot keep the context as is because some files are included multiple times.

My ideal solution would be to have, for example, the "CRname" as part of the anchor/link to ensure there are no "id already assigned" warnings.

@Lennonka
Copy link
Contributor Author

Lennonka commented Oct 19, 2023

Actually, this problem came up with a modification in our downstream branding. The context in the links has been like this for a while (even before #2492), it seems that we forgot to update our UI links. Therefore, it isn't an issue and I'm closing this.

@Lennonka Lennonka closed this Oct 19, 2023
@Lennonka Lennonka deleted the fix-context-provisioning branch October 19, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants