First updates #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ekohl
reviewed
Oct 17, 2023
foreman_theme_satellite.gemspec
Outdated
| s.metadata = { "is_foreman_plugin" => "true" } | ||
| s.license = 'GPL-3.0' | ||
| s.authors = ['Alon Goldboim, Shimon Stein'] | ||
| s.email = ['[email protected]'] |
There was a problem hiding this comment.
Do we have a better email address?
There was a problem hiding this comment.
It comes down to the definition of "we".
In Foreman, we can (and do in some cases) use dev@community.
But we are not in Foreman here, so maybe not?
We could ask @ShimShtein nicely if he wants to be listed here for now
ehelms
approved these changes
Oct 19, 2023
|
they are required |
Came here to link theforeman/foreman-documentation#2542 (comment) which concluded they were needed. |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.