Unnecessary IIFEs pervasive in v4 implementation

[dead-claudia]

I was just looking at the source out of curiosity, and found a lot of seemingly unnecessary IIFEs in the collapse (1, 2) and tab (1, 2, 3, 4, 5, 6) implementations. Is there a particular reason for these, or should they be removed?

[thednp]

The method is used because there is no cross-browser setImmediate method, and that fixes something reported over and over. I know it's not the most elegant method, but it's really hard to schedule those functions in that exact order, so, yea, it just works IE8+ no problem.

But I am open to any code suggestion you might have, consider backward compatibility as well.

[dead-claudia]

@thednp I'm not referring to the setTimeout calls, but the plain IIFEs themselves, things like this:

(function () {
    // code...
})();

As for that bug fix, all you really did beyond adding the unnecessary IIFEs was move code into setTimeout callbacks and increasing their delay.

As for backwards compatibility, just inlining their bodies should have zero impact, even as far back as Netscape. Any differences would be obvious browser breakers, leaving almost all common sites with scripting unusable.

[thednp]

@isiahmeadows as I said, I am open to any code suggestion, I really tried them all I know.

[dead-claudia]

@thednp Check out #140. That should explain what I mean (it's also a nicely packaged PR).

[thednp]

Wowow, wait a sec and check this first before committing.

Have you tested multiple clicks and it works perfect? I've spent about 2 days working to fix that issue, you think that would simplify and solve the issue for good? Also make sure the events are triggered when they should really trigger :)

[dead-claudia]

It's equivalent to what's already there, and I have tested it to verify it does not break in Chrome.

[thednp]

I am now testing your code in all browsers. It seems to work, but I don't know...

[dead-claudia]

In case you're curious (I can tell you're not super familiar with the difference), here's the Wikipedia article on the idiom.

[thednp]

OK. I remember now. FYI: I am not targeting G Chrome only, I am interested in IE8+ for BSN V3 and IE10+ for BSN V4. I also have a very old Safari for Windows.... My wild code there is meant to make it work in all the browsers consistently.

So, you know why those IIFEs are used? It's because the API on event.transitionEnd is poorly implemented in many browsers and it always messes up... sometimes things that need to happen when the animation ends, never happen, or the event is not even triggered.

So FYI, please take the time to test differences with all functionalities in regards to components custom events, browsers, consistency, etc ;)

[thednp]

@chenull I hope you take a look at @isiahmeadows' commit as well. Thank you.

[dead-claudia]

@thednp IIFE's are just a lanugage idiom, unique to JS the language, without respect to the environment. They do literally nothing apart from creating a new scope for var variables.

[thednp]

@isiahmeadows I will certainly do a mega test with your suggestion as soon as I get some time. Thank you.