Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse component on Demo page will stop to functioning after several clicks using chrome #115

Closed
chenull opened this issue Feb 16, 2017 · 13 comments
Assignees
Labels
bug critical issue
Milestone

Comments

@chenull
Copy link

chenull commented Feb 16, 2017

In chrome Version 56.0.2924.87 (64-bit), the Collapse Component on demo page will stop functioning after some number of clicks. sometimes a few clicks, sometimes a lot. The corresponding JS log The show/hidden.bs.collapse event fired is stopped too. After i cloned this repo and checkout to gh-pages, and trying to reverting/bisect commits, i found this issue started after 369c3ea... Replaced `duration` option with `transitionEnd`. The commit before that, which is e4dbfaf... Removed isIE detection utility from V4 is ok. I can click the collapse action many many times

Note: This doesn't happen in Safari

@thednp
Copy link
Owner

thednp commented Feb 16, 2017

Does this happen after the last commit? 0e7aa35

@thednp
Copy link
Owner

thednp commented Feb 16, 2017

@chenull ?

@chenull
Copy link
Author

chenull commented Feb 17, 2017

Hi, i git pulled the last commit, fire up simple http server, do the clicks from chrome, and whenever the collapse stop working, i copy-pasted logs from JS console and here the result:

for log in clicks-*; do echo -n $log; cat $log | wc -l; done
clicks-01      88
clicks-02     124
clicks-03      92
clicks-04       3
clicks-05     147
clicks-06     379
clicks-07      19
clicks-08       3
clicks-09     115
clicks-10      15

so yes, it still happen, though it takes longer to be happen than my first time i visit your demo page. only happen twice with 3 clicks. it was happen quicker before.

@thednp
Copy link
Owner

thednp commented Feb 17, 2017

Cannot reproduce, the demo works properly for me, but I suspect why it happens on your end.

@chenull
Copy link
Author

chenull commented Feb 17, 2017

yeah, me too, it's hard to reproduce after your last commit. but i managed to create a gif animation when this happen

raisoclick-export

https://cloud.githubusercontent.com/assets/1737556/23052857/458833e2-f507-11e6-8f0e-2c5b76029892.gif

@chenull
Copy link
Author

chenull commented Feb 17, 2017

oh.. one more thing to note that, when it stopped working. the current collapsed item (the lorem ipsum text) is always in hidden condition. then next click, which should be the show event, is not happening.

@thednp
Copy link
Owner

thednp commented Feb 17, 2017

@chenull please confirm this test for the tabs example, it involves a similar isssue I hope I fixed.

@thednp
Copy link
Owner

thednp commented Feb 17, 2017

@chenull are you in Linux? On my Windows 8.1 with Google Chrome, Firefox and IE10 everything works perfect, I am now typing from Ubuntu, and I confirm the issue persists.

I believe this must be related to the fact that Linux is a bit slower executing some nested setTimeout functions and it gets stuck somewhere, but I am now working with Linux and working on a fix to make it full proof.

@thednp
Copy link
Owner

thednp commented Feb 17, 2017

I think I fixed the issue, I will do some tests in Windows with IE10 and commit asap.

thednp added a commit that referenced this issue Feb 17, 2017
thednp added a commit that referenced this issue Feb 17, 2017
@thednp thednp added the bug critical issue label Feb 17, 2017
@thednp thednp added this to the 2.0.5 milestone Feb 17, 2017
@thednp
Copy link
Owner

thednp commented Feb 17, 2017

@chenull
Please test the latest commit ASAP. I will release a new tag once you confirm the issues to be fixed.

@chenull
Copy link
Author

chenull commented Feb 17, 2017

@thednp yeah it fixed 👍 i am on a mac though, not linux

@thednp
Copy link
Owner

thednp commented Feb 17, 2017

i am on a mac though, not linux

Same for me.. OK thanks for the confirm.

Enjoy the release.

@thednp thednp closed this as completed Feb 17, 2017
@chenjau
Copy link

chenjau commented Jun 23, 2017

After testing with hundreds of click, demo page I think this bug still exist in firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical issue
Projects
None yet
Development

No branches or pull requests

3 participants