-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse component on Demo page will stop to functioning after several clicks using chrome #115
Comments
Does this happen after the last commit? 0e7aa35 |
@chenull ? |
Hi, i git pulled the last commit, fire up simple http server, do the clicks from chrome, and whenever the collapse stop working, i copy-pasted logs from JS console and here the result: for log in clicks-*; do echo -n $log; cat $log | wc -l; done
clicks-01 88
clicks-02 124
clicks-03 92
clicks-04 3
clicks-05 147
clicks-06 379
clicks-07 19
clicks-08 3
clicks-09 115
clicks-10 15 so yes, it still happen, though it takes longer to be happen than my first time i visit your demo page. only happen twice with 3 clicks. it was happen quicker before. |
Cannot reproduce, the demo works properly for me, but I suspect why it happens on your end. |
yeah, me too, it's hard to reproduce after your last commit. but i managed to create a gif animation when this happen https://cloud.githubusercontent.com/assets/1737556/23052857/458833e2-f507-11e6-8f0e-2c5b76029892.gif |
oh.. one more thing to note that, when it stopped working. the current collapsed item (the lorem ipsum text) is always in hidden condition. then next click, which should be the |
@chenull please confirm this test for the tabs example, it involves a similar isssue I hope I fixed. |
@chenull are you in Linux? On my Windows 8.1 with Google Chrome, Firefox and IE10 everything works perfect, I am now typing from Ubuntu, and I confirm the issue persists. I believe this must be related to the fact that Linux is a bit slower executing some nested |
I think I fixed the issue, I will do some tests in Windows with IE10 and commit asap. |
@chenull |
@thednp yeah it fixed 👍 i am on a mac though, not linux |
Same for me.. OK thanks for the confirm. Enjoy the release. |
After testing with hundreds of click, demo page I think this bug still exist in firefox. |
In chrome Version 56.0.2924.87 (64-bit), the Collapse Component on demo page will stop functioning after some number of clicks. sometimes a few clicks, sometimes a lot. The corresponding JS log
The show/hidden.bs.collapse event fired
is stopped too. After i cloned this repo and checkout togh-pages
, and trying to reverting/bisect commits, i found this issue started after369c3ea... Replaced `duration` option with `transitionEnd`
. The commit before that, which ise4dbfaf... Removed isIE detection utility from V4
is ok. I can click the collapse action many many timesNote: This doesn't happen in Safari
The text was updated successfully, but these errors were encountered: