Allow disabling of RBD modprobe #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is the only driver modification necessary to support rexray/rexray#818. |
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 28.42% 28.42%
=======================================
Files 34 34
Lines 2016 2016
=======================================
Hits 573 573
Misses 1381 1381
Partials 62 62Continue to review full report at Codecov.
|
When RBD driver is running in a container, using `modprobe` to check if the RBD module is already inserted is not apprpriate. Keep that behavior as the default, but add a config option to disable it that can be used for container deployments.
codenrhoden
force-pushed
the
feature/rbd_plugin
branch
from
fb7aa46 to
9e76b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When RBD driver is running in a container, using
modprobeto check ifthe RBD module is already inserted is not apprpriate. Keep that
behavior as the default, but add a config option to disable it that can
be used for container deployments.