Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Docker managed plugin for Ceph RBD #898

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

codenrhoden
Copy link
Member

@codenrhoden codenrhoden commented Jun 19, 2017

Plugin image requires that we have the Ceph CLI/tools in the container,
so this plugin is built off of CentOS 7 instead of Alpine. As such, the
plugin has customized versions of rexray.sh and Dockerfile instead of
the common ones.

Closes #818.

@codenrhoden
Copy link
Member Author

This PR requires thecodeteam/libstorage#576.

I've tested on CentOS7 and Ubuntu 16.04. Also tested to make sure that this image, which is based on Ceph kraken (latest release), works with a host and cluster install of Ceph Jewel (latest stable release). That is likely to be a common scenario, if not the majority of installs.

@codecov-io
Copy link

codecov-io commented Jun 19, 2017

Codecov Report

Merging #898 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #898   +/-   ##
======================================
  Coverage    8.79%   8.79%           
======================================
  Files          25      25           
  Lines        2980    2980           
======================================
  Hits          262     262           
  Misses       2682    2682           
  Partials       36      36

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efdd0f...b02d97a. Read the comment docs.

Copy link
Member

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me code-wise, but we should get @cduchesne to test it. After that I say merge away.

Plugin image requires that we have the Ceph CLI/tools in the container,
so this plugin is built off of CentOS 7 instead of Alpine. As such, the
plugin has customized versions of rexray.sh and Dockerfile instead of
the common ones.
@akutz akutz merged commit 3968744 into rexray:master Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants