feat: Add reauthorizeDataAccess method to LoginManager #204
Conversation
neilco
changed the title
mikehardy
added
the
needs more info
|
You've got to love it when something tells you there's an issue, but no what the actual issue is. Maybe you need to tweak your prettier config? It's fixed in 8b8e9fc. |
I think local prettier integrations (like the one in VScode at least, which you indicate you are using?) do look at the local .prettierrc and do tell you - either way because of the way prettier is, you just need to run it and that's that - but this is something that would be best in a pre-commit hook yeah - no reason to wait till it hits CI to see it |
There was a problem hiding this comment.
looks really good now, happy to approve + merge + release in just a moment, and though it doesn't matter now it appears that the alternative RCT_NNNNN method was just in case there was a symbol collision exporting the method? Interesting - makes sense I guess, just never seen it needed in any of the other repos I've worked on. Learn something every day...
mikehardy
added
pending-merge
mikehardy
removed
the
pending-merge
## [7.2.0](v7.1.0...v7.2.0) (2022-02-21) ### Features * Add reauthorizeDataAccess method to LoginManager ([#204](#204)) ([4aa7ff6](4aa7ff6))
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary: To help us review the request, please complete the following: - [x] sign [contributor license agreement](https://code.facebook.com/cla) - [x] I've ensured that all existing tests pass and added tests (when/where necessary) - [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary) - [ ] I've added the proper label to this pull request (e.g. `bug` for bug fixes) ## Pull Request Details 👋 hello from the [react-native-fbsdk-next](https://github.com/thebergamo/react-native-fbsdk-next) maintainer 😄 I would like the `reauthorizeDataAccess` ViewController param to conform to the nullability documented for it, and acceptable to the methods it passes the param to Pull Request resolved: #2477 Test Plan: Untested (not entirely true, we've been [actively sending nil through this API](https://github.com/thebergamo/react-native-fbsdk-next/pull/204/files#diff-17f183fc0de77f22952fc0fddd688c62adde2533c3dc32798d9f836390f08454R110) since [our first implementation using the API](thebergamo/react-native-fbsdk-next#204), and it's worked fine) Fixes #2476 Differential Revision: D67113142 Pulled By: yuriy-tolstoguzov fbshipit-source-id: 5fdc24b84cb2e10caceb928eb6df123452a0e66e
This pull request replicates the functionality added in facebookarchive/react-native-fbsdk#720 in order to facilitate the requesting of data access permissions when they have expired. The native Facebook SDK exposes a method on the LoginManager class (
reauthorizeDataAccess) that the changes in this pull request exposes to the JS layer.Test Plan:
We've modified the example app to call the new method. We've also tested this with a separate app to verify the code is behaving as expected.