Skip to content

Commit

Permalink
Make ViewController nullable param in reauthorizeDataAccess (#2477)
Browse files Browse the repository at this point in the history
Summary:
To help us review the request, please complete the following:

- [x] sign [contributor license agreement](https://code.facebook.com/cla)
- [x] I've ensured that all existing tests pass and added tests (when/where necessary)
- [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary)
- [ ] I've added the proper label to this pull request (e.g. `bug` for bug fixes)

## Pull Request Details

👋  hello from the [react-native-fbsdk-next](https://github.com/thebergamo/react-native-fbsdk-next) maintainer 😄

I would like the `reauthorizeDataAccess` ViewController param to conform to the nullability documented for it, and acceptable to the methods it passes the param to

Pull Request resolved: #2477

Test Plan:
Untested (not entirely true, we've been [actively sending nil through this API](https://github.com/thebergamo/react-native-fbsdk-next/pull/204/files#diff-17f183fc0de77f22952fc0fddd688c62adde2533c3dc32798d9f836390f08454R110) since [our first implementation using the API](thebergamo/react-native-fbsdk-next#204), and it's worked fine)

Fixes #2476

Differential Revision: D67113142

Pulled By: yuriy-tolstoguzov

fbshipit-source-id: 5fdc24b84cb2e10caceb928eb6df123452a0e66e
  • Loading branch information
mikehardy authored and facebook-github-bot committed Dec 13, 2024
1 parent d26ce60 commit a5ae682
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion FBSDKLoginKit/FBSDKLoginKit/LoginManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public final class LoginManager: NSObject {
*/
@objc(reauthorizeDataAccess:handler:)
public func reauthorizeDataAccess(
from viewController: UIViewController,
from viewController: UIViewController?,
handler: @escaping LoginManagerLoginResultBlock
) {
guard
Expand Down

0 comments on commit a5ae682

Please sign in to comment.