Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nightly Boards [n]87 and [n]2 #241

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Conversation

DeskDaily
Copy link
Contributor

@DeskDaily DeskDaily commented Jul 31, 2020

Description

Adding the json files for 2 of my keyboards: [n]87 and [n]2. Both are tested working with the via software

QMK Pull Request

n87: qmk/qmk_firmware#9885

n2: qmk/qmk_firmware#9886

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@DeskDaily DeskDaily changed the title Nightlyboards via Add Nightlyboards [n]87 and [n]2 Jul 31, 2020
@DeskDaily DeskDaily changed the title Add Nightlyboards [n]87 and [n]2 Add Nightly Boards [n]87 and [n]2 Jul 31, 2020
@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Aug 4, 2020
@DeskDaily
Copy link
Contributor Author

Both boards are now merged on the qmk repo

@wilba
Copy link
Contributor

wilba commented Aug 11, 2020

Can you add keys with "decal" checked for the blockers? They do not need a switch matrix coordinate but they do need the layout option "2,1" in the bottom right.
image

src/nightly_boards/n87.json Outdated Show resolved Hide resolved
@wilba wilba merged commit 2367318 into the-via:master Sep 15, 2020
@DeskDaily DeskDaily deleted the nightlyboards_via branch May 6, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants