Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add via keymap folder for N2 keyboard #9886

Merged
merged 9 commits into from
Aug 6, 2020
Merged

Add via keymap folder for N2 keyboard #9886

merged 9 commits into from
Aug 6, 2020

Conversation

DeskDaily
Copy link
Contributor

Description

Added a via keymap for n2. Tested working with the VIA software

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@DeskDaily DeskDaily mentioned this pull request Jul 31, 2020
Merged
6 tasks
drashna
drashna approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add a config.h file that allows for a bunch more layers, if you wanted. But given the limited number of keys... This may be fine.

@drashna drashna requested a review from a team August 5, 2020 07:10
@drashna drashna added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 5, 2020
@noroadsleft noroadsleft merged commit b8438c7 into qmk:master Aug 6, 2020
@noroadsleft
Copy link
Member

Thanks!

@DeskDaily DeskDaily deleted the n2_via branch August 6, 2020 13:37
fdawans pushed a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@DeskDaily @fdawans
[Keymap] Add via keymap folder for N2 keyboard (qmk#9886)
62b8150 
* Create Alter folder

* Revert "Create Alter folder"

This reverts commit 361103b.

* Add via keymap folder for n2 keyboard
fdawans added a commit to fdawans/qmk_firmware that referenced this pull request Aug 11, 2020
@fdawans
Revert "[Keymap] Add via keymap folder for N2 keyboard (qmk#9886)"
a0c5770 
This reverts commit 62b8150.
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@DeskDaily @nicocesar
[Keymap] Add via keymap folder for N2 keyboard (qmk#9886)
6cca048 
* Create Alter folder

* Revert "Create Alter folder"

This reverts commit 361103b.

* Add via keymap folder for n2 keyboard
fcoury pushed a commit to fcoury/qmk_firmware_archive that referenced this pull request Sep 20, 2020
@DeskDaily @fcoury
[Keymap] Add via keymap folder for N2 keyboard (qmk#9886)
dbf4b66 
* Create Alter folder

* Revert "Create Alter folder"

This reverts commit 361103b.

* Add via keymap folder for n2 keyboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeskDaily @noroadsleft @drashna