Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctrl-M #2385

Merged
merged 8 commits into from
Dec 22, 2024
Merged

Add ctrl-M #2385

merged 8 commits into from
Dec 22, 2024

Conversation

nuess0r
Copy link
Contributor

@nuess0r nuess0r commented Dec 9, 2024

Description

Add ctrl-M replacement controller for the IBM Model M 101/102

Detailed description of the ctrl-M controller:
https://brain4free.org/wiki/doku.php/elektronik:ctrl_m

QMK Pull Request

Link to merged QMK Pull Request:

qmk/qmk_firmware#24375

VIA Keymap Pull Request

VIA keymap PR:

the-via/qmk_userspace_via#40

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • VIA keymap is MERGED in VIA userspace master already (MANDATORY)
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have a V3 JSON version for this keyboard definition.(MANDATORY)
  • I have formatted the JSON file to have consistent formatting with the rest of the repository.
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

src/ibm/model_m/ctrl_m/ctrl_m.json Outdated Show resolved Hide resolved
@Cipulot
Copy link
Collaborator

Cipulot commented Dec 18, 2024

@nuess0r pull the changes I applied to format the file and please move the file from the src directory to v3.
v3 is the current directory to be used, src is for V2 and legacy usage.

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Dec 18, 2024
@nuess0r
Copy link
Contributor Author

nuess0r commented Dec 21, 2024

@Cipulot thanks for the review. I moved it now to the correct folder. Either I missed the correct folder in the via documentation or it was too small that I recognized it. Sorry for that :-)

@Cipulot
Copy link
Collaborator

Cipulot commented Dec 22, 2024

@nuess0r thx, dw about it, looks all good now, merging.

@Cipulot Cipulot merged commit 48a1123 into the-via:master Dec 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants