Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request ID for ctrl-M replacement controller for the IBM Model M 101/102 #51

Merged
merged 1 commit into from
May 6, 2023

Conversation

nuess0r
Copy link
Contributor

@nuess0r nuess0r commented Apr 29, 2023

ctrl-M Controller for Model M keyboards

This is a replacement controller for the famous IBM Model M keyboard based on the STM32F072 microcontroller.

Hardware:
https://github.com/nuess0r/ctrl-M
Released under CERN-OHL-S

Software:
QMK https://github.com/nuess0r/qmk_firmware/tree/ctrl_m/keyboards/ibm/model_m/ctrl_m
Released under GPL 2.0

@cuvoodoo
Copy link
Collaborator

cuvoodoo commented May 3, 2023

hardware repo looks fine (copyright present, license present, sources complete, schematic/board export present).
only the qmk firmware repo is missing the LICENSE file. The license info is in the source headers, but it is still recommended to have this additional file, particularly because the original project you fork already includes it.
once the LICENSE file for the qmk firmware repo is present, you are good to go and I'll merge the PR.

@nuess0r
Copy link
Contributor Author

nuess0r commented May 4, 2023

@cuvoodoo Thanks for the review.
I'm a bit confused, which file you are missing. The qmk repository has one in the top folder: https://github.com/nuess0r/qmk_firmware/blob/ctrl_m/LICENSE

Do you miss something else?

@cuvoodoo
Copy link
Collaborator

cuvoodoo commented May 6, 2023

sorry, the mistake was on my side. I only looked at the ctrl_m additions of the the firmware, and forgot that this is actually in a subfolder. all is fine.

@cuvoodoo cuvoodoo merged commit 321d1a5 into openmoko:master May 6, 2023
nuess0r added a commit to nuess0r/keyboards that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants