-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP -- inline widgets & block editing modals #301
Merged
Changes from 27 commits
Commits
Show all changes
167 commits
Select commit
Hold shift + click to select a range
e0aca6b
wip pm 0.11.1
forresto 23c342f
onChange
forresto 66bdcf0
redo fixed menu
forresto 195ecaf
update deps
forresto 6af9191
Merge branch 'master' into pm-0-11-1
forresto 409f816
up deps
forresto 7ffbd0b
lint: give up on :deciduous_tree: comma-style
forresto 2e658b5
old pm :ghost:
forresto a6c9fa5
up deps
forresto e5d8d8d
Merge branch 'master' into pm-0-11-1
forresto c7b5b41
up deps
forresto b7778d4
deps
forresto 609a5db
eslint dangle
forresto a819594
eslint fix fixture
forresto 944c3b4
inline media start :heart:
forresto d19ef9d
lint tweaks
forresto 2419259
:tada: react widgets inline :relieved:
forresto c5d59fc
fix textarea-autosize initial height
forresto 0c9620b
widgets inline :boom: #289
forresto 3b71d5d
removeEventListener cleanup
forresto 1fb2eb2
keymap command schema shuffle
forresto f68a2e2
rename EdSchema
forresto 95d335e
keymap order fix li split
forresto f3d516c
insert from menu
forresto 68e9e09
_replaceBlock and _insertBlocks
forresto be0a166
iframe key
forresto 068fb12
cover safety
forresto ebcfbab
wrong state :flushed:
forresto 744f34f
fixed-menu-hack new plugin
forresto 43d5944
plugin destroy
forresto 32eadb4
_insertBlocks expects array
forresto 28a68ba
plugins/placeholder naïve
forresto 917f883
plugins/share-url
forresto 8c3e916
lint
forresto b9c9f2b
hide hints for now
forresto abe8c24
less renders for MediaNodeView
forresto f1e8a25
bad-behaving plugin!
forresto 66214fb
plugins/placeholder decorations
forresto 742dbb8
edStuff for plugin options
forresto ead53ae
:thought_balloon:
forresto b60b70d
rename some args
forresto 07ff54e
fix a widget glitch
forresto f1902cb
focusedIndex default 0
forresto bd5f888
cleanup
forresto 287b40c
move onMount
forresto 4edc124
hr for "fold"
forresto 3e823e7
start to fix tests :confetti_ball:
forresto 798ad7f
fixed-menu-hack w/ pm 016
forresto 9d9a84c
fix reinit fixed-menu-hack
forresto a25b215
boundSpaceContent
forresto 310c3c0
boundSpaceContent :expressionless:
forresto d59757a
init with lastMenuHeight = 0
forresto e74ca47
don't need =>
forresto a95a085
placeholder for headings
forresto ee4939b
fix share-url store call
forresto 9f5b675
update commands-interface
forresto 9563285
patch deps
forresto 5ad6ccd
GridToDoc spec: height and focus out
forresto c8747e5
remove PluginContentHints spec
forresto dad53a1
fix PluginPlaceholder spec
forresto 4094f5a
PluginWidget spec
forresto 17d3dad
PluginKey to get store from state
forresto c5cb65d
spec ed.execCommand
forresto 78eacb8
lint
forresto 3540521
2.0.0-0
forresto b162ef3
v2.0.0-0 prerelease changes
forresto adc6600
BREAKING -- use onMount
forresto 59bf7ef
2.0.0-1
forresto df9de37
fix menuBar: false
forresto 26c3c84
2.0.0-2
forresto 40b8960
bump imgflo-url
forresto 5af22ab
actually, state
forresto aa738a9
changes 2.0.0-3
forresto 43b46fe
2.0.0-3
forresto 547d4cc
disable _convertToFullPost
forresto 2507d76
pm17
forresto e230f6a
pm17 change event
forresto 8659a80
unused plugins
forresto b218e9e
pm17 plugins/placeholder
forresto d655688
pm17 store
forresto 7f60fd5
pm17 plugins/share-url
forresto bc05e22
pm17 plugins/commands-interface
forresto b793f7f
pm17 execCommand
forresto 1ebb224
pm17 _removeMediaBlock
forresto da6437b
up deps
forresto 736432c
spec for empty content
forresto 94795ff
url modal attached to menu
forresto 410f237
prefill url-like selection; fix #288
forresto 1fd65e5
lint
forresto 0358d29
changes 2.0.0-4
forresto 6bca820
2.0.0-4
forresto e0b501f
dist/.nojekyll for demo
forresto 47282d6
Fix link menu form position
forresto 8678b1a
React issue, `confirm` prop on `a`
forresto 6c194de
don't listen focus to dismiss
forresto 5747954
lint
forresto eb9282a
fix file drop
forresto df8c9ae
lint
forresto 060124c
changes 2.0.0-5
forresto 2da1962
2.0.0-5
forresto e76d211
Fixed menu hack only on iOS
forresto ff5b597
drop util tweaks
forresto 50fb09f
don't need resize on focus
forresto 630c238
lint
forresto 038b3c5
no inline react textarea
forresto 1f6cae5
revert widget view stuff
forresto 485db1c
smaller images
forresto c73932b
Revert "revert widget view stuff"
forresto 929c189
widget view unsalv cover fields
forresto 7b91c2f
style tweaks
forresto 560bb26
default block view: flex it
forresto eefd3da
widget border cleanup
forresto fffde87
widget select and move cursor
forresto 16b9070
up deps
forresto eae8353
fix tests
forresto 38636ec
lint
forresto a0983de
media click to select node
forresto a6266db
modal starting to work
forresto 64b7371
open and close modal
forresto e5664c4
lint
forresto 01d671f
modal bg click close
forresto 92783ab
view failed, progress
forresto f5ce529
update inline view from modal editor
forresto 1dc839d
big cta
forresto 71da251
Merge pull request #304 from the-grid/refactor/editor-modals
b853751
ios position hack for modal
forresto 3d9f9c1
changes 2.0.0-7 prerelease
forresto 83eab99
2.0.0-6
forresto 900d363
fix changes
forresto b638925
don't type over node
forresto 319bf25
2.0.0-7
forresto 2265f09
Merge branch 'master' into pm-0-11-1
forresto 998efb5
update iframe tests
forresto 238cf3c
lint
forresto 5fe4859
fix node select focus bug
forresto a90a9b9
modal bg more alpha
forresto 2d5b976
changes 2.0.0-8
forresto 3f5c1be
2.0.0-8
forresto e1690a9
fix blur
forresto 34e79b8
default coverPrefs
forresto a8e2340
don't select node on edit mouse
forresto bcbe8c9
widget style shuffle
forresto 3b21c2e
refactor modal
forresto 60570a8
scroll margin for footer
forresto 4d6e16b
enter to close menu and modal
forresto 42b1670
no select draggable
forresto 934ecc0
iframe drag handle
forresto 48b900d
select unsupported
forresto 02d2cb7
delete block wording and close
forresto 262c2db
simplify onMouseDown select
forresto 3b02255
iframe widget name
forresto 3fdd583
link 'Starts with http'
forresto 6e65def
changes 2.0.0-9 prerelease
forresto 2e8da44
2.0.0-9
forresto f4bf5c8
node v7.4.0
forresto 259f53b
2.0.0-10
forresto 1fcd890
Merge featureFlags from 1.4.x
forresto 8df5b53
lint
forresto 10973b4
ed.version; close #306
forresto 4388f20
don't break layout with long url
forresto 567c56a
url input
forresto 8f44bcd
show type & link icon
forresto 32af88e
make hr easier to tap #302
forresto ce0e454
attribution view
forresto 909aa6c
changes
forresto 4e8231c
2.0.0-11
forresto 052aba5
changes 2.0.0
forresto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
{ "parser": "babel-eslint" | ||
, "ecmaFeatures": { "modules": true } | ||
, "env": | ||
{ "browser": true | ||
, "node": true | ||
, "es6": true | ||
} | ||
, "rules": | ||
{ "no-multiple-empty-lines": [2, {"max": 2, "maxEOF": 1}] | ||
, "no-console": 2 | ||
, "comma-style": [2, "first"] | ||
, "camelcase": 0 | ||
, "indent": 0 | ||
} | ||
, "plugins": ["react"] | ||
, "extends": ["standard", "plugin:react/recommended"] | ||
} | ||
{ | ||
"parser": "babel-eslint", | ||
"ecmaFeatures": { "modules": true }, | ||
"env": { | ||
"browser": true, | ||
"node": true, | ||
"es6": true | ||
}, | ||
"rules": { | ||
"no-multiple-empty-lines": [2, {"max": 2, "maxEOF": 1}], | ||
"comma-dangle": [2, "always-multiline"], | ||
"no-console": 2, | ||
"camelcase": 0 | ||
}, | ||
"plugins": ["react"], | ||
"extends": ["standard", "plugin:react/recommended"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not have done it in the same PR tho 😳