WIP -- inline widgets & block editing modals #301

forresto · 2016-12-20T03:41:43Z

pr goals... net negative loc

@narrowdesign QA finds:

getting 404 on code and map
Can’t add attributions but can delete the ones you slugged in (Cole Rise etc). Can’t toggle ✅
no feedback when clicking … > add X from images or quotes.
It either feels weird to be able to add a link to a word in an image title/quote or weird that it doesn’t work after I do it.
clicking ” when focus is inside an image or another quote creates a quote wherever the cursor was before last focus change.
- Note: last two are the same issue, and I noticed the same bug in PM demo: https://discuss.prosemirror.net/t/nodeview-selection-bug/565

I see some jumping in Safari, but it's Safari bugs that I'm working around with the positioning hacks. ~~~Going to roll with it for now.~~~

fix so that only iOS uses the hacks and other browsers are smoother

1/20 @narrowdesign QA:

Not regressions / not blockers

Can't clear paragraph break when photo is the first thing there is
Can't click between images to add text. (I see that you're adding paragraph breaks between them. But I delete those instinctively every time. Now that I know why they are there I won't.)
Rolling over linked text shows pointer but doesn't give an option to link
Links in text aren't editable. Clicking the link button turns the link off and has to be redone.

Webapp issues

Can't type a full quote attribution link without it clearing what I am typing before it is a valid link. Was able to type http://cnn.com once and it stuck. Must be clearing if not valid after Nseconds.
Image load bar doesn't clear after loaded. Also there in the edit mode.
Hide the close button when modal is open, it's easily confused for "close modal" but it takes you all the way out to cards view.
Link menu looks inactive (tried a couple to be sure it wasn't the color scheme's issue

this is too much for one commit, sorry. everything broke, fixed basic text editing and formatting. to fix: * widgets * menu

# Conflicts: # src/components/editable-menu.css # src/components/editable.js # src/menu/menu-media.js

# Conflicts: # package.json # src/components/app.js # src/components/dropdown-group.js

for PM updates #289 todo: fix pos > 0

aretecode · 2016-12-21T12:12:30Z

.eslintrc

+  "rules": {
+    "no-multiple-empty-lines": [2, {"max": 2, "maxEOF": 1}],
+    "comma-dangle": [2, "always-multiline"],


Should not have done it in the same PR tho 😳

aretecode · 2016-12-21T12:12:52Z

package.json

-    "babel-eslint": "6.1.2",
-    "babel-loader": "6.2.4",
-    "babel-preset-es2015": "6.9.0",
+    "babel-cli": "6.18.0",


aretecode · 2016-12-21T12:16:41Z

src/convert/grid-to-doc.js

@@ -26,7 +27,7 @@ export default function (items) {
      if (el) container.appendChild(el)
    })
  }
-  return EdSchema.parseDOM(container)
+  return DOMParser.fromSchema(EdSchema).parse(container)


Nice naming cleanup

aretecode · 2016-12-21T12:17:20Z

src/inputrules/ed-input-rules.js


-const rules = inputRules.allInputRules.concat(edRules)
+// const isIOS = /iPad|iPhone|iPod/.test(navigator.userAgent) && !window.MSStream


no longer needed?

With pm15... https://discuss.prosemirror.net/t/release-0-15-0/519

The main change in this release is that a bunch more things (typing, in-textblock backspacing) are left to the browser, and ProseMirror takes care not to re-render content when it doesn't have to. Which goes exactly against the original concept of ProseMirror ('never trust the browser, we'll do it ourselves'), but more and more issues came up where browser or platform features, such as spell-check, long-press to type character variants on OS, double-space for a period on iOS, were broken because the browser and/or the OS didn't realize what was going on.

So for relatively uncontroversial functionality (there's not too much disagreement on what should happen to your document when you type a character), the editor now takes a hands-off approach.

@narrowdesign

@narrowdesign 🎁

forresto · 2017-01-20T20:31:05Z

@narrowdesign

you can select an empty ¶ with focus + escape then backspace to delete
you can add a paragraph between images selecting one then pressing enter
- unless image is first block, then it will add empty ¶ before it

These are ProseMirror default behaviors. Would there be a better path?

& iframe and unsupported border

forresto · 2017-01-20T21:15:41Z

(Though that doesn't help mobile, where OSK disappears on block selection. Menu items for "delete block" & "add paragraph above" would help.)

# Conflicts: # CHANGES.md # demo/demo.js # package.json # src/components/app.js # src/components/editable.js # src/menu/ed-menu.js # src/plugins/commands-interface.js # src/plugins/widget-base.js # src/plugins/widget-iframe.js # src/plugins/widget.css # src/plugins/widget.js

forresto · 2017-01-24T22:12:40Z

Almost down to polish.

forresto added 19 commits October 10, 2016 21:32

wip pm 0.11.1

e0aca6b

this is too much for one commit, sorry. everything broke, fixed basic text editing and formatting. to fix: * widgets * menu

onChange

23c342f

redo fixed menu

66bdcf0

update deps

195ecaf

Merge branch 'master' into pm-0-11-1

6af9191

# Conflicts: # src/components/editable-menu.css # src/components/editable.js # src/menu/menu-media.js

up deps

409f816

lint: give up on 🌳 comma-style

7ffbd0b

old pm 👻

2e658b5

up deps

a6c9fa5

Merge branch 'master' into pm-0-11-1

e5d8d8d

# Conflicts: # package.json # src/components/app.js # src/components/dropdown-group.js

up deps

c7b5b41

deps

b7778d4

eslint dangle

609a5db

eslint fix fixture

a819594

inline media start ❤️

944c3b4

lint tweaks

d19ef9d

🎉 react widgets inline 😌

2419259

fix textarea-autosize initial height

c5d59fc

widgets inline 💥 #289

0c9620b

This was referenced Dec 20, 2016

WIP -- nix overlays #143

Closed

update to pm 0.15.x #289

Closed

forresto added 8 commits December 20, 2016 09:14

removeEventListener cleanup

3b71d5d

keymap command schema shuffle

1fb2eb2

rename EdSchema

f68a2e2

keymap order fix li split

95d335e

insert from menu

f3d516c

_replaceBlock and _insertBlocks

68e9e09

for PM updates #289 todo: fix pos > 0

iframe key

be0a166

cover safety

068fb12

aretecode reviewed Dec 21, 2016

View reviewed changes

forresto added 3 commits January 20, 2017 14:37

refactor modal

3b21c2e

scroll margin for footer

60570a8

enter to close menu and modal

4d6e16b

@narrowdesign 🎁

forresto added 3 commits January 20, 2017 15:36

no select draggable

42b1670

iframe drag handle

934ecc0

& iframe and unsupported border

select unsupported

48b900d

forresto added 18 commits January 20, 2017 16:23

delete block wording and close

02d2cb7

simplify onMouseDown select

262c2db

iframe widget name

3b02255

link 'Starts with http'

3fdd583

changes 2.0.0-9 prerelease

6e65def

2.0.0-9

2e8da44

node v7.4.0

f4bf5c8

2.0.0-10

259f53b

lint

8df5b53

ed.version; close #306

10973b4

don't break layout with long url

4388f20

url input

567c56a

show type & link icon

8f44bcd

make hr easier to tap #302

32af88e

attribution view

ce0e454

changes

909aa6c

2.0.0-11

4e8231c

changes 2.0.0

052aba5

forresto merged commit 89cf23a into master Jan 25, 2017

forresto deleted the pm-0-11-1 branch January 25, 2017 21:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP -- inline widgets & block editing modals #301

WIP -- inline widgets & block editing modals #301

forresto commented Dec 20, 2016 •

edited

Loading

aretecode Dec 21, 2016

forresto Dec 21, 2016

aretecode Dec 21, 2016

aretecode Dec 21, 2016

aretecode Dec 21, 2016

forresto Dec 21, 2016

forresto commented Jan 20, 2017

forresto commented Jan 20, 2017

forresto commented Jan 24, 2017


		const rules = inputRules.allInputRules.concat(edRules)
		// const isIOS = /iPad\|iPhone\|iPod/.test(navigator.userAgent) && !window.MSStream

WIP -- inline widgets & block editing modals #301

WIP -- inline widgets & block editing modals #301

Conversation

forresto commented Dec 20, 2016 • edited Loading

@narrowdesign QA finds:

1/20 @narrowdesign QA:

Not regressions / not blockers

Webapp issues

aretecode Dec 21, 2016

Choose a reason for hiding this comment

forresto Dec 21, 2016

Choose a reason for hiding this comment

aretecode Dec 21, 2016

Choose a reason for hiding this comment

aretecode Dec 21, 2016

Choose a reason for hiding this comment

aretecode Dec 21, 2016

Choose a reason for hiding this comment

forresto Dec 21, 2016

Choose a reason for hiding this comment

forresto commented Jan 20, 2017

forresto commented Jan 20, 2017

forresto commented Jan 24, 2017

forresto commented Dec 20, 2016 •

edited

Loading