Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rimraf by del-cli #932

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Replace rimraf by del-cli #932

merged 1 commit into from
Dec 27, 2022

Conversation

th-ch
Copy link
Owner

@th-ch th-ch commented Dec 26, 2022

From #905 it seems rimraf is raising issues on Windows, this PR replaces it with del.

@Zo-Bro-23
Copy link
Contributor

Great!

@th-ch th-ch merged commit 453fe3f into master Dec 27, 2022
@th-ch th-ch deleted the rimraf-del branch December 27, 2022 16:28
@Araxeus
Copy link
Collaborator

Araxeus commented Jan 19, 2023

@Zo-Bro-23 wanna try again with the new rimraf version? [3.0.2 --> 4.1.1]

https://www.npmjs.com/package/rimraf/v/4.1.1

it supposedly got revamped, might work better for you now

@Zo-Bro-23
Copy link
Contributor

@Zo-Bro-23 wanna try again with the new rimraf version? [3.0.2 --> 4.1.1]

https://www.npmjs.com/package/rimraf/v/4.1.1

it supposedly got revamped, might work better for you now

Well, if del is working fine, there's no reason to switch back to rimraf, but if we face issues with del then we can consider switching back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants