-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme.md #905
Update readme.md #905
Conversation
Also added a GitHub Actions workflow to build the app. I'm only familiar with Windows, so it only supports Windows at the moment, but feel free to add jobs for Mac and Linux too! |
Added Linux build support to the action too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme change looks good (apart from one line), the rest should not be needed, unless I missed something?
readme.md
Outdated
``` | ||
1. Clone the repo | ||
2. Run ```yarn``` | ||
3. Run ```npm i rimraf``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rimraf is already a dependency so this step should not be needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rimraf is already a dependency so this step should not be needed!
Removed this line!
.github/workflows/release.yml
Outdated
@@ -0,0 +1,127 @@ | |||
on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this will do the same as the build workflow, no? (it already takes care of publishing the artifacts to GH releases)
There seems to be an error regarding Also, can you approve the change to |
Hi... |
Hi, this is not the place to post suggestions. I've reposted this for you in issues (#922). Please add further comments and discussions there. Thank you! |
For the time being, if you don't approve of the changes to |
Updated README with more precise build instructions (#559)