Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update in-app-menu #596

Merged
merged 7 commits into from
Feb 20, 2022
Merged

update in-app-menu #596

merged 7 commits into from
Feb 20, 2022

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Feb 6, 2022 •
edited
Loading

  • Big performance improvement
  • Doesn't require electron@remote anwhere anymore
  • Radio buttons now have their own icon (finally... 😅)
    image

tested with the changes in AlexTorresDev/custom-electron-titlebar#175

also:

  • adds a full screen button to the view submenu (which allows using the f11 shortcut)
  • lighten up selected menuItem background color (better contrast/visibility against the mostly black menu)

@Araxeus Araxeus mentioned this pull request Feb 6, 2022
Merged
@Araxeus Araxeus marked this pull request as ready for review February 15, 2022 16:59
@Araxeus
Copy link
Collaborator Author

Araxeus commented Feb 15, 2022 •
edited
Loading

@th-ch custom-electron-titlebar v4.1.0 was released, this pr should be safe to merge

@Araxeus Araxeus mentioned this pull request Feb 15, 2022
Merged
th-ch
th-ch approved these changes Feb 20, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! ✅

@th-ch th-ch merged commit 2dd208c into th-ch:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @th-ch