Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate from remote to ipc + fix restart in portable app #605

Merged
merged 15 commits into from
Jun 6, 2022
Merged

migrate from remote to ipc + fix restart in portable app #605

merged 15 commits into from
Jun 6, 2022

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Feb 15, 2022 •
edited
Loading

704fba9 fix #620

can easily test directories using

	win.webContents.send('log', { 
		execPath: process.execPath, // temporary exe in portable mode + electron.exe in dev mode
		argv0: process.argv0, // same as execPath
		PORTABLE_EXECUTABLE_DIR: process.env.PORTABLE_EXECUTABLE_DIR, // directory of portable.exe
		PORTABLE_EXECUTABLE_FILE: process.env.PORTABLE_EXECUTABLE_FILE, // full path to portable.exe
		PORTABLE_EXECUTABLE_APP_FILENAME: process.env.PORTABLE_EXECUTABLE_APP_FILENAME, // = 'youtube music'
		INIT_CWD: process.env.INIT_CWD,
		PWD: process.env.PWD
	});

@Araxeus Araxeus marked this pull request as ready for review February 20, 2022 17:35
@Araxeus Araxeus mentioned this pull request Feb 24, 2022
Closed
@Araxeus Araxeus force-pushed the migrate-from-remote-to-ipc branch from 5dc26a9 to 704fba9 Compare February 24, 2022 18:52
@Araxeus Araxeus changed the title migrate from remote to ipc migrate from remote to ipc + fix restart in portable app Feb 24, 2022
@Araxeus Araxeus force-pushed the migrate-from-remote-to-ipc branch 2 times, most recently from bf219d8 to 3ead3e2 Compare March 21, 2022 16:18
@Araxeus
update Electron
bed8d0a 
+ update electron-unhandled
@Araxeus Araxeus force-pushed the migrate-from-remote-to-ipc branch from 3ead3e2 to bed8d0a Compare March 30, 2022 15:48
@Araxeus Araxeus mentioned this pull request Apr 10, 2022
Merged
@Araxeus Araxeus force-pushed the migrate-from-remote-to-ipc branch from 67605ad to 7bd69e4 Compare April 30, 2022 12:24
th-ch
th-ch approved these changes Jun 6, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

@th-ch th-ch merged commit 86a1c3c into th-ch:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restart App close the app
2 participants
@Araxeus @th-ch