Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filenamify playlist folder name #557

Merged
merged 1 commit into from
Jan 23, 2022
Merged

filenamify playlist folder name #557

merged 1 commit into from
Jan 23, 2022

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Jan 18, 2022 •
edited
Loading

Bug: playlist folder had no name sanitation, causing a silent error on mkdirSync() when downloading playlists with invalid characters in the name

fix part of #556

note: replacement could be _ instead of  

@Araxeus Araxeus mentioned this pull request Jan 18, 2022
Closed
@Araxeus Araxeus force-pushed the fix-filepath-error branch from 63010b2 to cb92019 Compare January 18, 2022 16:32
th-ch
th-ch approved these changes Jan 23, 2022
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix! ✅

@th-ch th-ch merged commit 61eb236 into th-ch:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @th-ch