Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some songs will not download #556

Closed
valkyrienyanko opened this issue Jan 17, 2022 · 1 comment · Fixed by #1054
Closed

Some songs will not download #556

valkyrienyanko opened this issue Jan 17, 2022 · 1 comment · Fixed by #1054

Comments

@valkyrienyanko
Copy link

Some songs just say "Downloading..." forever, but other songs download just fine.

Steps to Reproduce

  1. Search for "big shot deltarune drum and bass version"
  2. Try downloading the first top result

OS: Windows 64 Bit
@Araxeus
Copy link
Collaborator

Araxeus commented Jan 18, 2022 •
edited
Loading

There are actually 2 bugs here

  1. The first search result which is named "Top Result" sometimes has a bug:

    • menu doesn't contain the song url like all other menus - instead containing some random playlist url
      (could only reproduce once, anyways this is a bug in youtube website and not the program)

  2. playlist folder has no name sanitation, meaning that if the playlist name has invalid characters, mkdirSync() will throw an error at - FIXED in filenamify playlist folder name #557

@Araxeus Araxeus mentioned this issue Jan 18, 2022
Merged
@Araxeus Araxeus mentioned this issue Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[downloader] plugin overhaul Araxeus/youtube-music
2 participants
@valkyrienyanko @Araxeus