Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squad radio TTS #15961
Squad radio TTS #15961
Changes from 18 commits
0be9485
fd489d5
cc9d58b
eb2b746
e871b3e
211d26c
7a07839
be93484
cb78c13
22b4b6f
f30d583
4edebaa
ae6aaa8
cbf08e9
4d113f6
fd2840f
d522f53
35c313d
f2c152c
3468e08
f718eaf
ac689c3
17307f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll instead want to modify the backend so that you can pass in an option to disable directionality for a specific request. This is generally a lot more inefficient than just passing in a list of potential hearers as you're making a lot of HTTP requests when you only really need to make 1. Also, it'll fall into the same problems of the same person speaking where they're able to speak over themselves, which can kinda hurt the illusion of TTS.
Best thing to do is to just add another option to queue_tts_message that lets you set some
directional
var to FALSE. Pass that into the TTS request, then in the subsystem beforeplay_tts
, pass that in and disable directionality/range checks if it is set to FALSE.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, you could just add them all up into a list and send it to TTS subsystem in one go.
Add a variable for
directionality
If it's set, ignore turf source and play at source.