Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squad radio TTS #15961

Merged
merged 23 commits into from
Sep 28, 2024
Merged

Squad radio TTS #15961

merged 23 commits into from
Sep 28, 2024

Conversation

breadhunt
Copy link
Contributor

@breadhunt breadhunt commented May 31, 2024

About The Pull Request

TM -- Couldn't test on local due to TTS not working there. It compiles and it should work, but better safe than sorry.

Three Four TTS modes added for headset: SL, Squad, Command, and all other channels. Set in game settings prefs.

"All" reads out all comms, full stop
"Squad" reads out all messages in your squad channel (e.g if you're in Alpha it'll read out all messages in the Alpha channel). (This is default).
"SL Only" reads out all messages in your squad channel by your SL.
"None" disables radio TTS functionality entirely. (This is default).

Why It's Good For The Game

One of the biggest problems with playing in a squad: nobody can actually fucking hear you. Squad comms are a tiny bit of text in the bottom right of the screen which nobody looks at while being mauled by a ravager. TTS should help this by providing more responsive comms.
Alongside #15960 this should also make escort and tadpole squads able to easily communicate, hopefully reducing a lot of the frustration that comes with cross-map coordination.

Option to opt-out should minimise TTS spam. Hopefully this'll let a lot more cool teamwork shenanigans emerge

Changelog

🆑
add: Added a "TTS mode" for headsets which reads out any messages sent in your squad channel (if you have one). Can be set as "SL", "SQUAD", "COMMAND" and "ALL (except Squad and Command)" in prefs.
/:cl:

@tgstation-server tgstation-server added Merge Conflict Pull request is in a conflicted state with base branch. Feature New interesting mechanics with new interesting bugs labels May 31, 2024
@novaepee
Copy link
Contributor

thank god for no tts for general

@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Jun 1, 2024
@Lauwma
Copy link
Contributor

Lauwma commented Jun 1, 2024

How does that work for FC and shipside ?

@TiviPlus TiviPlus self-assigned this Jun 1, 2024
@breadhunt
Copy link
Contributor Author

How does that work for FC and shipside ?

They don't have squad, so it doesn't affect them

@breadhunt
Copy link
Contributor Author

Still ready for testing whenever btw

Copy link
Member

@TiviPlus TiviPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for tm?

Comment on lines 314 to 315
braindeath.'
- rscadd: 'Combat Robot advice: immediate defibrillation, no critical condition.'
- rscadd: 'Combat Robot advice: immediate defibrillation, no critical condition.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random eof linechange

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jun 15, 2024
comfyorange added a commit that referenced this pull request Jun 19, 2024
comfyorange added a commit that referenced this pull request Jun 20, 2024
comfyorange added a commit that referenced this pull request Jun 20, 2024
@CoastalCookie
Copy link

CoastalCookie commented Jun 20, 2024

If you have it set to "ALL" after a while it will stop giving tts voices don't know what causes this specifically though

Removing headset or swapping modes etc. Does not fix it

comfyorange added a commit that referenced this pull request Jun 20, 2024
@breadhunt
Copy link
Contributor Author

half of this does not work, I will work on a fix soon:TM:

@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jun 20, 2024
@breadhunt
Copy link
Contributor Author

disclaimer: please let me know if this is still broken after it gets re-TMd

comfyorange added a commit that referenced this pull request Jun 21, 2024
comfyorange added a commit that referenced this pull request Sep 8, 2024
comfyorange added a commit that referenced this pull request Sep 9, 2024
comfyorange added a commit that referenced this pull request Sep 10, 2024
comfyorange added a commit that referenced this pull request Sep 10, 2024
comfyorange added a commit that referenced this pull request Sep 12, 2024
comfyorange added a commit that referenced this pull request Sep 13, 2024
comfyorange added a commit that referenced this pull request Sep 14, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Sep 16, 2024
comfyorange added a commit that referenced this pull request Sep 16, 2024
@Kuro020 Kuro020 removed the Stale Pull request is awaiting delayed author response and may be closed. label Sep 16, 2024
comfyorange added a commit that referenced this pull request Sep 17, 2024
comfyorange added a commit that referenced this pull request Sep 18, 2024
comfyorange added a commit that referenced this pull request Sep 18, 2024
comfyorange added a commit that referenced this pull request Sep 18, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Sep 26, 2024
TiviPlus and others added 2 commits September 28, 2024 17:15
@TiviPlus TiviPlus added Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. and removed Stale Pull request is awaiting delayed author response and may be closed. labels Sep 28, 2024
@TiviPlus
Copy link
Member

This needs work but it's good enough and has been sitting a while

@TiviPlus TiviPlus merged commit 64f1142 into tgstation:master Sep 28, 2024
39 checks passed
github-actions bot added a commit that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.