-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Squad radio TTS #15961
Squad radio TTS #15961
Conversation
thank god for no tts for general |
How does that work for FC and shipside ? |
They don't have squad, so it doesn't affect them |
Still ready for testing whenever btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok for tm?
html/changelogs/archive/2024-05.yml
Outdated
braindeath.' | ||
- rscadd: 'Combat Robot advice: immediate defibrillation, no critical condition.' | ||
- rscadd: 'Combat Robot advice: immediate defibrillation, no critical condition.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random eof linechange
If you have it set to "ALL" after a while it will stop giving tts voices don't know what causes this specifically though Removing headset or swapping modes etc. Does not fix it |
half of this does not work, I will work on a fix soon:TM: |
disclaimer: please let me know if this is still broken after it gets re-TMd |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Co-authored-by: ivanmixo <[email protected]>
Co-authored-by: ivanmixo <[email protected]>
This needs work but it's good enough and has been sitting a while |
About The Pull Request
TM -- Couldn't test on local due to TTS not working there. It compiles and it should work, but better safe than sorry.
ThreeFour TTS modes added for headset: SL, Squad, Command, and all other channels. Set in game settings prefs."All" reads out all comms, full stop
"Squad" reads out all messages in your squad channel (e.g if you're in Alpha it'll read out all messages in the Alpha channel). (This is default).
"SL Only" reads out all messages in your squad channel by your SL.
"None" disables radio TTS functionality entirely.
(This is default).Why It's Good For The Game
One of the biggest problems with playing in a squad: nobody can actually fucking hear you. Squad comms are a tiny bit of text in the bottom right of the screen which nobody looks at while being mauled by a ravager. TTS should help this by providing more responsive comms.
Alongside #15960 this should also make escort and tadpole squads able to easily communicate, hopefully reducing a lot of the frustration that comes with cross-map coordination.
Option to opt-out should minimise TTS spam. Hopefully this'll let a lot more cool teamwork shenanigans emerge
Changelog
🆑
add: Added a "TTS mode" for headsets which reads out any messages sent in your squad channel (if you have one). Can be set as "SL", "SQUAD", "COMMAND" and "ALL (except Squad and Command)" in prefs.
/:cl: