Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base-cluster/monitoring): send Watchdog alert to null if deadmansswitch is not configured #1120

Merged

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented Aug 21, 2024

No description provided.

@cwrau cwrau enabled auto-merge (squash) August 21, 2024 09:13
tasches
tasches previously approved these changes Aug 21, 2024
@tasches tasches self-requested a review August 21, 2024 09:19
@tasches tasches disabled auto-merge August 21, 2024 09:19
@tasches tasches dismissed their stale review August 21, 2024 09:23

waiting for pipeline

@cwrau cwrau enabled auto-merge (squash) August 21, 2024 09:24
tasches
tasches previously approved these changes Aug 21, 2024
@teutonet-bot
Copy link
Contributor

teutonet-bot commented Aug 21, 2024

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

charts/base-cluster/ci/monitoring-ingress-unauthenticated-values.yaml

charts/base-cluster/ci/rbac-values.yaml has no changes

charts/base-cluster/ci/pagerduty-values.yaml

charts/base-cluster/ci/velero-backupStorageLocations-gen-values.yaml

charts/base-cluster/ci/flux-gitrepositories-gen-values.yaml

charts/base-cluster/ci/imagepullsecrets-values.yaml has no changes

charts/base-cluster/values.yaml has no changes

charts/base-cluster/ci/artifacthub-values.yaml

charts/base-cluster/ci/disabled-ingress-values.yaml

charts/base-cluster/ci/priorityclasses-values.yaml

charts/base-cluster/ci/deadmansswitch-values.yaml

charts/base-cluster/ci/monitoring-oidc-values.yaml

charts/base-cluster/ci/basic-values.yaml has no changes

charts/base-cluster/ci/monitoring-oidc-ingress-disabled-values.yaml

charts/base-cluster/ci/limitrange-resourcequota-values.yaml

@cwrau cwrau force-pushed the fix/base-cluster/send-watchdog-to-null-without-deadmansswitch branch from 41b2fad to 0e0a36e Compare August 21, 2024 15:42
@cwrau cwrau requested a review from tasches August 21, 2024 15:43
@tasches tasches force-pushed the fix/base-cluster/send-watchdog-to-null-without-deadmansswitch branch from 0e0a36e to a7e7051 Compare August 22, 2024 12:15
@cwrau cwrau merged commit 1e93c60 into main Aug 22, 2024
12 checks passed
@cwrau cwrau deleted the fix/base-cluster/send-watchdog-to-null-without-deadmansswitch branch August 22, 2024 12:53
cwrau pushed a commit that referenced this pull request Sep 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[6.7.0](base-cluster-v6.6.3...base-cluster-v6.7.0)
(2024-08-30)


### Features

* **base-cluster/tetragon:** add tetragon
([#1056](#1056))
([9be7543](9be7543))


### Bug Fixes

* **base-cluster/kube-prometheus-stack:** only disable
PrometheusNotConnectedToAlertmanagers when Alertmanager is disabled as
well
([#1053](#1053))
([dbb007a](dbb007a))
* **base-cluster/monitoring:** send Watchdog alert to `null` if
deadmansswitch is not configured
([#1120](#1120))
([1e93c60](1e93c60))


### Miscellaneous Chores

* **base-cluster/dependencies:** pin docker.io/vladgh/gpg docker tag to
1ba48a7
([#1076](#1076))
([23aa2dc](23aa2dc))
* **base-cluster/dependencies:** update common docker tag to v1.2.1
([#1080](#1080))
([25ec4e8](25ec4e8))
* **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker
tag to v1.29.8
([#1060](#1060))
([93f059a](93f059a))
* **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker
tag to v1.31.0
([#907](#907))
([8544d01](8544d01))
* **base-cluster/dependencies:** update docker.io/bitnami/kubectl:1.29.6
docker digest to 6f94559
([#1027](#1027))
([075d171](075d171))
* **base-cluster/dependencies:** update docker.io/curlimages/curl docker
tag to v8.9.1
([#1079](#1079))
([8f1a39c](8f1a39c))
* **base-cluster/dependencies:** update external-dns docker tag to v8
([#1021](#1021))
([9eb94aa](9eb94aa))
* **base-cluster/dependencies:** update helm release
kube-prometheus-stack to v62
([#1145](#1145))
([8ab376a](8ab376a))
* **base-cluster/dependencies:** update helm release velero to v7.1.5
([#1134](#1134))
([32e0769](32e0769))
* **base-cluster/dependencies:** update oauth2-proxy docker tag to v6
([#1146](#1146))
([9885aba](9885aba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants