fix(base-cluster/kube-prometheus-stack): only disable PrometheusNotConnectedToAlertmanagers when Alertmanager is disabled as well #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrau
requested review from
marvinWolff,
tasches and
teutonet-bot
as code owners
marvinWolff
reviewed
Aug 1, 2024
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_alertmanager-config.yaml
Show resolved
Hide resolved
PrometheusNotConnectedToAlertmanagers when Alertmanager is disabled as well
cwrau
force-pushed
the
fix/base-cluster/prometheus-alertmanager-alerts
branch
from
50dac12 to
bfdc782
Compare
marvinWolff
approved these changes
Aug 30, 2024
cwrau
pushed a commit
that referenced
this pull request
Sep 3, 2024
🤖 I have created a release *beep* *boop* --- ## [6.7.0](base-cluster-v6.6.3...base-cluster-v6.7.0) (2024-08-30) ### Features * **base-cluster/tetragon:** add tetragon ([#1056](#1056)) ([9be7543](9be7543)) ### Bug Fixes * **base-cluster/kube-prometheus-stack:** only disable PrometheusNotConnectedToAlertmanagers when Alertmanager is disabled as well ([#1053](#1053)) ([dbb007a](dbb007a)) * **base-cluster/monitoring:** send Watchdog alert to `null` if deadmansswitch is not configured ([#1120](#1120)) ([1e93c60](1e93c60)) ### Miscellaneous Chores * **base-cluster/dependencies:** pin docker.io/vladgh/gpg docker tag to 1ba48a7 ([#1076](#1076)) ([23aa2dc](23aa2dc)) * **base-cluster/dependencies:** update common docker tag to v1.2.1 ([#1080](#1080)) ([25ec4e8](25ec4e8)) * **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.29.8 ([#1060](#1060)) ([93f059a](93f059a)) * **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.31.0 ([#907](#907)) ([8544d01](8544d01)) * **base-cluster/dependencies:** update docker.io/bitnami/kubectl:1.29.6 docker digest to 6f94559 ([#1027](#1027)) ([075d171](075d171)) * **base-cluster/dependencies:** update docker.io/curlimages/curl docker tag to v8.9.1 ([#1079](#1079)) ([8f1a39c](8f1a39c)) * **base-cluster/dependencies:** update external-dns docker tag to v8 ([#1021](#1021)) ([9eb94aa](9eb94aa)) * **base-cluster/dependencies:** update helm release kube-prometheus-stack to v62 ([#1145](#1145)) ([8ab376a](8ab376a)) * **base-cluster/dependencies:** update helm release velero to v7.1.5 ([#1134](#1134)) ([32e0769](32e0769)) * **base-cluster/dependencies:** update oauth2-proxy docker tag to v6 ([#1146](#1146)) ([9885aba](9885aba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.