Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: bitwise, bit shift, boolean SIMD instructions #628

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

mathetake
Copy link
Member

@mathetake mathetake commented Jun 16, 2022

This implements bit shit, bitwise and boolean SIMD instructions for
arm64 backend.

Notably, now the impl passes simd_bitwise.json simd_boolean.json,
and simd_bit_shift spectests.

Signed-off-by: Takeshi Yoneda [email protected]

part of #484

@mathetake mathetake changed the title arm64: bitwise, logical shift SIMD instructions arm64: bitwise, bit shift SIMD instructions Jun 16, 2022
@mathetake mathetake changed the title arm64: bitwise, bit shift SIMD instructions arm64: bitwise, bit shift, boolean SIMD instructions Jun 16, 2022
@mathetake
Copy link
Member Author

ok the left is boolean instructions!

@@ -1276,374 +1275,6 @@ func TestAssemblerImpl_EncodeTwoSIMDBytesToSIMDByteRegister(t *testing.T) {
}
}

func TestAssemblerImpl_EncodeVectorRegisterToVectorRegister(t *testing.T) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are migrated to asm/arm64/impl_tes.go

@mathetake mathetake marked this pull request as ready for review June 17, 2022 02:22
Signed-off-by: Takeshi Yoneda <[email protected]>
Makefile Show resolved Hide resolved
Signed-off-by: Takeshi Yoneda <[email protected]>
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe check if impl_vec_arm64_test.go is missing any tests of significance. Otherwise, I guess it is up to the spec_test to notice.

internal/asm/arm64/consts.go Outdated Show resolved Hide resolved
internal/asm/arm64/consts.go Show resolved Hide resolved
internal/asm/arm64/impl_test.go Show resolved Hide resolved
Signed-off-by: Takeshi Yoneda <[email protected]>
@mathetake mathetake merged commit 338652a into main Jun 17, 2022
@mathetake mathetake deleted the bitboolarm64 branch June 17, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants