-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arm64: bitwise, bit shift, boolean SIMD instructions #628
Conversation
ok the left is boolean instructions! |
@@ -1276,374 +1275,6 @@ func TestAssemblerImpl_EncodeTwoSIMDBytesToSIMDByteRegister(t *testing.T) { | |||
} | |||
} | |||
|
|||
func TestAssemblerImpl_EncodeVectorRegisterToVectorRegister(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are migrated to asm/arm64/impl_tes.go
Signed-off-by: Takeshi Yoneda <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe check if impl_vec_arm64_test.go is missing any tests of significance. Otherwise, I guess it is up to the spec_test to notice.
Signed-off-by: Takeshi Yoneda <[email protected]>
This implements bit shit, bitwise and boolean SIMD instructions for
arm64 backend.
Notably, now the impl passes
simd_bitwise.json
simd_boolean.json
,and
simd_bit_shift
spectests.Signed-off-by: Takeshi Yoneda [email protected]
part of #484