Add withFileSystemBind + name parameters
#206
Conversation
| @@ -8,6 +8,7 @@ class FixedHostPortGenericContainer(imageName: String, | |||
| env: Map[String, String] = Map(), | |||
| command: Seq[String] = Seq(), | |||
| classpathResourceMapping: Seq[(String, String, BindMode)] = Seq(), | |||
| fileSystemBind: Seq[(String, String, BindMode)] = Seq(), | |||
There was a problem hiding this comment.
would you mind moving this argument to be last? it'll help to protect those who use positional arguments
| @@ -33,16 +35,19 @@ object FixedHostPortGenericContainer { | |||
| env: Map[String, String] = Map(), | |||
| command: Seq[String] = Seq(), | |||
| classpathResourceMapping: Seq[(String, String, BindMode)] = Seq(), | |||
| fileSystemBind: Seq[(String, String, BindMode)] = Seq(), | |||
| @@ -21,6 +21,7 @@ class GenericContainer( | |||
| env: Map[String, String] = Map(), | |||
| command: Seq[String] = Seq(), | |||
| classpathResourceMapping: Seq[(String, String, BindMode)] = Seq(), | |||
| fileSystemBind: Seq[(String, String, BindMode)] = Seq(), | |||
There was a problem hiding this comment.
And in this class please
| @@ -10,7 +10,8 @@ class FixedHostPortGenericContainer(imageName: String, | |||
| classpathResourceMapping: Seq[(String, String, BindMode)] = Seq(), | |||
| waitStrategy: Option[WaitStrategy] = None, | |||
| exposedHostPort: Int, | |||
| exposedContainerPort: Int | |||
| exposedContainerPort: Int, | |||
| fileSystemBind: Seq[(String, String, BindMode)] = Seq() | |||
There was a problem hiding this comment.
Sorry for the delay. Just realized that I haven't submitted another comment - would it make sense to introduce a case class instead of tuple? otherwise, we need to make it more easier to understand what first two string params are.
There was a problem hiding this comment.
It makes sense to have that, what do you think is the best place to put such case class? as a name, I'm thinking about FileSystemBinding and we can use it also for the classpath binding (even if it's a change break, but at least we are consistent). Let me know your thoughts ;)
There was a problem hiding this comment.
Yes, I think it's reasonable
|
@benkio apologies for the delay and missing a comment, hope it makes sense. |
|
hi @dimafeng |
|
@benkio Thank you! |
Related to issue #205