Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing withFileSystemBind in GenericContainer #205

Closed
benkio opened this issue Jan 14, 2022 · 1 comment
Closed

Missing withFileSystemBind in GenericContainer #205

benkio opened this issue Jan 14, 2022 · 1 comment

Comments

@benkio
Copy link
Contributor

benkio commented Jan 14, 2022

Hi there,
I'm trying to use a GenericContainer, move jar on it, run the command etc etc
Then I wish to get the output result of such a command that writes on a specific container's path. On testcontainers-java I see that the GenericContainer has withFileSystemBind method that links a host's directory to a container's one.
https://github.com/testcontainers/testcontainers-java/blob/master/core/src/main/java/org/testcontainers/containers/GenericContainer.java#L1001

I was expecting to find it in the repo as the classpathResourceMapping parameter is exposed in the constructor, but found none.
Do you think is worth adding it? It should be easy and a mirror of the classpathResourceMapping
Cheers

@dimafeng
Copy link
Collaborator

Yes, it's definitely worth adding. I'd really appreciate if you submit a PR with that fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants