Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct default for get_host_ip_address in case of unix or npipe #613

Merged
merged 2 commits into from
Apr 29, 2024
Merged

fix: correct default for get_host_ip_address in case of unix or npipe #613

merged 2 commits into from
Apr 29, 2024

Commits on Apr 29, 2024

  1. fix: correct default for get_host_ip_address 

    `IpAddr` can't be parsed from `localhost`, it expects domain.

We could use `url::Host`, but it would be a breaking change and method must be renamed in that case
    @DDtKey
    DDtKey committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6873c14 View commit details
    Browse the repository at this point in the history

  2. fix: correct default value for get_host_ip_address in case of `unix… 

    …` or `npipe`

`IpAddr` can't be parsed from `localhost`, it expects domain.

We could use `url::Host`, but it would be a breaking change and method must be renamed in that case
    @DDtKey
    DDtKey committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ce76bc4 View commit details
    Browse the repository at this point in the history