fix: correct default for get_host_ip_address in case of unix or npipe
#613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IpAddr` can't be parsed from `localhost`, it expects domain. We could use `url::Host`, but it would be a breaking change and method must be renamed in that case
…` or `npipe` `IpAddr` can't be parsed from `localhost`, it expects domain. We could use `url::Host`, but it would be a breaking change and method must be renamed in that case
DDtKey
changed the title
get_host_ip_address in case of unix or npipeget_host_ip_address in case of unix or npipe
This was referenced Apr 29, 2024
Closed
Merged
DDtKey
pushed a commit
that referenced
this pull request
Apr 29, 2024
## 🤖 New release * `testcontainers`: 0.16.4 -> 0.16.5 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.16.5] - 2024-04-29 ### Details #### Bug Fixes - Correct drop of a network for sync container ([#612](#612)) - Correct default for `get_host_ip_address` in case of `unix` or `npipe` ([#613](#613)) #### Miscellaneous Tasks - Update `serde-java-properties` to `0.2.0` ([#614](#614)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IpAddrcan't be parsed fromlocalhost, it expects domain.We could use
url::Host, but it would be a breaking change and method must be renamed in that case