Add autoUpdateExternalUrl to CloudStorageEmulatorContainer
#825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alecmev
commented
Aug 27, 2024
Comment on lines
-103
to
-108
| public getExternalUrl(): string { | ||
| if (this._externalURL) { | ||
| return this._externalURL; | ||
| } else { | ||
| return this.getEmulatorEndpoint(); | ||
| } |
There was a problem hiding this comment.
Removed this fallback because undefined is a valid state (i.e., "not set"), and _externalURL will usually be up-to-date, thanks to updateExternalUrl.
cristianrgreco
added
enhancement
|
Both errors appear to be unrelated to this PR, do I need to do anything? |
|
Thank you 👍 |
|
Thank you, released in https://github.com/testcontainers/testcontainers-node/releases/tag/v10.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously discussed here: #805 (comment)
Defaulting to
truebecause it's very likely that the container will be used locally, and that it's desired for the emulator to return valid URLs. If anexternalUrlis provided then the update is skipped.Can't get tests to work with Colima (I added
forListeningPortsbut it hangs inInternalPortCheck.isBound, here), so need a CI run to check.