-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CloudStorageEmulatorContainer
and PubSubEmulatorContainer
to gcloud module
#805
Add CloudStorageEmulatorContainer
and PubSubEmulatorContainer
to gcloud module
#805
Conversation
Adds two new emulator containers to the `gcloud`-package: - `CloudStorageEmulatorContainer`: Cloud Storage - `PubSubEmulatorContainer`: Cloud PubSub The Cloud PubSub emalator container uses the same approach as used by the existing containers of using the `gcloud cli` tos tart the PubSub emulator. The Cloud Storage emulator container uses an existing fake GCS emulator named `fsouza/fake-gcs-server`.
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @weyert, could you review the lint issues? Should be a case of running |
CloudStorageEmulatorContainer
and PubSubEmulatorContainer
to gcloud module
@weyert Looks like some tests are failing
|
@weyert Will you look into why the tests are failing? Merging main won't fix them. Same for the with platform PR |
…ntainers-node into add-pubsub-emulator
# Conflicts: # package-lock.json
@cristianrgreco I have made some changes this week to make it pass but the workflows aren't running here so I made a second PR in my own repo and there the tests succeeded: https://github.com/weyert/testcontainers-node/actions/runs/10334199546/job/28607861739 Only problem is that the Selenium tests are failing. |
This reverts commit a182f61.
@cristianrgreco Anything else needed to get this merged? |
Hi @weyert, I'll run the build now. Could you add a few lines in the docs as done here? https://github.com/testcontainers/testcontainers-node/blob/693ea8c26b62975de581f8a38f0ce39d214d31f1/docs/modules/gcloud.md#firestore-datastore-mode |
@cristianrgreco I updated the documentation to add both mention the new |
Thanks for implementing this! Would have saved me some time back in May 😛 Have you considered adding automatic |
Disregard, I forgot that this is a Colima quirk. Let me know if you'd like to add these improvements yourself, or prefer that I do it. |
I could saved myself time by finding your example for I mainly wrote these two containers as I want to test the integrations of two packages at work to ensure the behaviour is the same when using PubSub or Kafka, and between S3 and Cloud Storage :) |
Done 😉 #825 |
Adds two new emulator containers to the
gcloud
-package:CloudStorageEmulatorContainer
: Cloud StoragePubSubEmulatorContainer
: Cloud PubSubThe Cloud PubSub emalator container uses the same approach as used by the existing containers of using the
gcloud cli
tos tart the PubSub emulator.The Cloud Storage emulator container uses an existing fake GCS emulator named
fsouza/fake-gcs-server
.