feat: add meilisearch-module #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add module scaffolding
* main: feat: add yugabytedb module (testcontainers#2825) fix: update module container struct name and missing imports (testcontainers#2831)
* main: fix(reaper): refactor to allow retries and fix races (testcontainers#2728) chore: update ryuk to 0.10.2 (testcontainers#2833)
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Oct 18, 2024
stevenh
requested changes
Oct 18, 2024
|
@stevenh I addressed all your comments 🤞 |
Closed
|
@mdelapenya thank you for the help and the support. LGTM @mdelapenya @stevenh |
stevenh
requested changes
Oct 21, 2024
| testcontainers.CleanupContainer(t, ctr) | ||
| require.NoError(t, err) | ||
|
|
||
| t.Run("Connect to Address", func(t *testing.T) { |
There was a problem hiding this comment.
Looks like this was missed?
stevenh
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add Meilisearch Golang module
It takes all the commits in #2823, adding the commits needed to add the module to the docs system and the CI.
Why is it important?
Meilisearch is getting more popular and there Is already a java module for it.
Related issues