feat: add meilisearch #2823
feat: add meilisearch #2823
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
modules/meilisearch/meilisearch.go
Outdated
| // Deprecated: use Run instead | ||
| // RunContainer creates an instance of the Meilisearch container type | ||
| func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomizer) (*MeilisearchContainer, error) { | ||
| return Run(ctx, "getmeili/meilisearch:v1.10.3", opts...) | ||
| } |
There was a problem hiding this comment.
Seeing this block of code, I guess you copy-pasted some other module. Could you run the code generation tool for creating modules, as explained here?
It informs of the different alternatives to host the module (here in the core or in your own GH user as a community module), also creating the docs pages for the new module. Finally, it will update the files to include the new module in the CI, among others.
I'd suggest you run the tool first, checking that your code does not include Deprecated code (the tool does not include it)
Thanks!
There was a problem hiding this comment.
@mdelapenya yes true I copied paste from OpenSearch 😄
Ok sure I will run and re-request your review. Thank you @mdelapenya for the comment.
There was a problem hiding this comment.
I have a commit with the scaffolding, but I cannot push it because this branch is your main branch. I'll try to submit a PR to your branch so you can incorporate it into this one
|
@mashail not sure if you check out my previous comment in #2823 (comment), but I can help you out adding the needed changes on top of yours. Wdyt? |
modules/meilisearch/meilisearch.go
Outdated
| // Deprecated: use Run instead | ||
| // RunContainer creates an instance of the Meilisearch container type | ||
| func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomizer) (*MeilisearchContainer, error) { | ||
| return Run(ctx, "getmeili/meilisearch:v1.10.3", opts...) | ||
| } |
There was a problem hiding this comment.
I have a commit with the scaffolding, but I cannot push it because this branch is your main branch. I'll try to submit a PR to your branch so you can incorporate it into this one
@mdelapenya I invited you as a contributor |
chore: add module scaffolding
|
@mdelapenya I added the options to the docs |
|
@mdelapenya I rebased the branch if you may have a look |
|
#2835 is the right one, containing the initial commits from this one to preserve the authors. In fact, it will close this one when merged. |
|
Thanks I’m going to close this one manually to avoid any confusion |
What does this PR do?
Add Meilisearch Golang module
Why is it important?
Meilisearch is getting more popular and there Is already a java module for it.
Related issues