Fix up Buffer's handling of all the encodings #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natevw
force-pushed
the
nvw-buffer-encoding
branch
from
a3f421c to
2e89eb2
Compare
natevw
changed the title
|
This now passes all relevant tests (including a sizeable handful of new ones) and just got rebased off master. Please review. |
| @@ -186,7 +186,8 @@ function from_base64(to_decode) | |||
| local char = string.sub(to_decode, i, i) | |||
| local offset, _ = string.find(index_table, char) | |||
| if offset == nil then | |||
| error(js_new(global.Error, "Invalid character '" .. char .. "' found.")) | |||
| --error(js_new(global.Error, "Invalid character '" .. tm.str_from_binary(char) .. "' found.")) | |||
| // NOTE: Ideally these would deal with native uint16_t arrays, and have separate uint16_t<->uint8_t endian helper. | ||
| // But it doesn't seem worth the extra pain and potential performance hit right now. | ||
|
|
||
| #define IS_BIG_ENDIAN 0 // TODO |
There was a problem hiding this comment.
Probably add the same constants as https://github.com/tessel/runtime/pull/566/files#diff-989f5e7cdba84de885a494044d101f0bR205
There was a problem hiding this comment.
Ah, missed those, and when originally done I had a completely different arrangment of the code where I strongly desired an actual preprocessor constant. However now it makes sense to just use a host-to-le-short style function there.
|
TODOs so far:
|
|
(Sorry, meant to get this updated yesterday…planning on it first thing this afternoon!) |
natevw
added a commit
that referenced
this pull request
Nov 19, 2014
natevw
force-pushed
the
nvw-buffer-encoding
branch
from
e1fc152 to
e6e5ce0
Compare
natevw
added a commit
that referenced
this pull request
Nov 26, 2014
|
Okay I have:
@tcr wanna review again? |
|
What is the plan here? (This could give another speed bump to sdcard's fatfs speed due to workarounds it is using for lack of native utf16le support, btw.) |
… there but failing some tests
…have shared code in tm_str_to_X case but…meh?)
…s empty buffer on malformed base64
…uffer methods need, this way #566 will be able to share our tm_str_to_utf16 implemenattion
tcr
force-pushed
the
nvw-buffer-encoding
branch
from
e6e5ce0 to
93f31fc
Compare
|
Approved by @tcr. Running tests. |
tm-rampart
added a commit
that referenced
this pull request
Dec 15, 2014
Mild overhaul to finish up Buffer encoding work which was started in the ["Strings" pull request](#542) but wasn't really fully implemented or thoroughly checked over. Highlights: - adds utf16le encoding/decoding (which had been completely absent) - improves ascii/binary/hex/base64 logic too - generally cleaner in/out logic
tm-rampart
added a commit
to tessel/t1-firmware
that referenced
this pull request
Dec 15, 2014
|
Approved by @tcr. Running tests. |
tm-rampart
added a commit
that referenced
this pull request
Dec 15, 2014
Mild overhaul to finish up Buffer encoding work which was started in the ["Strings" pull request](#542) but wasn't really fully implemented or thoroughly checked over. Highlights: - adds utf16le encoding/decoding (which had been completely absent) - improves ascii/binary/hex/base64 logic too - generally cleaner in/out logic
tm-rampart
added a commit
to tessel/t1-firmware
that referenced
this pull request
Dec 15, 2014
|
Approved by @johnnyman727. Running tests. |
tm-rampart
added a commit
that referenced
this pull request
Dec 15, 2014
…ings Mild overhaul to finish up Buffer encoding work which was started in the ["Strings" pull request](#542) but wasn't really fully implemented or thoroughly checked over. Highlights: - adds utf16le encoding/decoding (which had been completely absent) - improves ascii/binary/hex/base64 logic too - generally cleaner in/out logic
tm-rampart
added a commit
to tessel/t1-firmware
that referenced
this pull request
Dec 15, 2014
…l the encodings
|
Approved by @johnnyman727. Running tests. |
tm-rampart
added a commit
that referenced
this pull request
Dec 15, 2014
…ings Mild overhaul to finish up Buffer encoding work which was started in the ["Strings" pull request](#542) but wasn't really fully implemented or thoroughly checked over. Highlights: - adds utf16le encoding/decoding (which had been completely absent) - improves ascii/binary/hex/base64 logic too - generally cleaner in/out logic
tm-rampart
added a commit
to tessel/t1-firmware
that referenced
this pull request
Dec 15, 2014
…l the encodings
natevw
added a commit
that referenced
this pull request
Feb 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mild overhaul to finish up Buffer encoding work which was started in the "Strings" pull request but wasn't really fully implemented or thoroughly checked over.
Highlights: