-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change RegExps to work on 16-bit wide characters on all platforms. Removes wchar_t refs #566
base: master
Are you sure you want to change the base?
Conversation
625aecc
to
debeeb0
Compare
Will dig through the comments and update this patch. (Github's interface is really confusing me with its comments UX today.) |
@natevw Updated. To recap, Also I printed out your string diagram and pasted it on our wall. |
15bb22e
to
383455c
Compare
Looking much better, although I think you should change the signature (and relevant internals) to |
@natevw I've changed the function definition to take a |
@tcr That works, sorry for not reviewing sooner. R+ assuming it actually works in practice too ;-) |
…uffer methods need, this way #566 will be able to share our tm_str_to_utf16 implemenattion
…uffer methods need, this way #566 will be able to share our tm_str_to_utf16 implemenattion
…uffer methods need, this way #566 will be able to share our tm_str_to_utf16 implemenattion
…uffer methods need, this way #566 will be able to share our tm_str_to_utf16 implemenattion
This removes the use of "mbtowcs", replacing it with an explicit UCS-2 function and and
hsregex
patch that fixes its characters to 16-bits wide.