Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#193 FIX Workspaces with no change plans not giving up lock #194

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

orbitz
Copy link
Contributor

@orbitz orbitz commented Dec 19, 2024

Inside the PR, the workspace is considered applied however it is holding on to the lock after being merged. This modified the SQL query to take the plan into account when looking at which locks are held.

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (explain):

Checklist

  • I have read the contributing guidelines
  • The pull request title follows this format:
    ISSUE_NUMBER ACTION_TYPE Short description (e.g., 123 ADD Feature description)
  • I have added tests and documentation (if applicable)
  • My changes generate no new warnings/errors and do not break existing functionality

Additional context (optional)

Inside the PR, the workspace is considered applied however it is
holding on to the lock after being merged.  This modified the SQL
query to take the plan into account when looking at which locks are
held.
@orbitz orbitz requested a review from a team as a code owner December 19, 2024 21:51
@orbitz orbitz merged commit 85e19da into main Dec 20, 2024
4 checks passed
@orbitz orbitz deleted the 193-fix-plans-with-no-changes-not-releasing-lock branch December 20, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants