Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans with no changes are considered applied in the PR but hold onto locks for other PRs #193

Closed
orbitz opened this issue Dec 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@orbitz
Copy link
Contributor

orbitz commented Dec 19, 2024

Describe the bug

When a plan results in no changes, in the PR Terrateam considers the workspace to be applied however when another PR tries to apply the same workspace, the first PR maintains a lock.

Steps to reproduce

No response

Expected behavior

No response

Actual behavior

No response

Terrateam version & environment details

No response

Additional context

No response

@orbitz orbitz added the bug Something isn't working label Dec 19, 2024
orbitz added a commit that referenced this issue Dec 19, 2024
Inside the PR, the workspace is considered applied however it is
holding on to the lock after being merged.  This modified the SQL
query to take the plan into account when looking at which locks are
held.
orbitz added a commit that referenced this issue Dec 20, 2024
…s-not-releasing-lock

#193 FIX Workspaces with no change plans not giving up lock
@orbitz orbitz closed this as completed Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant