New resource: aws_dx_transit_virtual_interface #8522

ewbankkit · 2019-05-03T19:56:03Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Part of the work for #8490.
Replaces #8514.

Acceptance tests (requires an existing Direct Connect connection in available state):

$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxTransitVirtualInterface_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxTransitVirtualInterface_ -timeout 120m
=== RUN   TestAccAwsDxTransitVirtualInterface_basic
=== PAUSE TestAccAwsDxTransitVirtualInterface_basic
=== CONT  TestAccAwsDxTransitVirtualInterface_basic
--- PASS: TestAccAwsDxTransitVirtualInterface_basic (1074.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1074.672s

n3ph

MTU of a transit virtual interface is 8500 - Not 9001

n3ph · 2019-05-07T13:50:33Z

website/docs/r/dx_transit_virtual_interface.html.markdown

+* `id` - The ID of the virtual interface.
+* `arn` - The ARN of the virtual interface.
+* `aws_device` - The Direct Connect endpoint on which the virtual interface terminates.
+* `jumbo_frame_capable` - Indicates whether jumbo frames (9001 MTU) are supported.


9001 vs. 8500

Whoops, missed that one; Fixed.

heycasey · 2019-07-23T22:33:21Z

@ewbankkit Do you know what is preventing this from being merged? I'd love to have this resource available

ewbankkit · 2019-07-24T12:08:54Z

@heycasey I'll fix the merge conflict.

ewbankkit · 2019-07-26T18:34:03Z

Rebased to fix merge conflict.
@n3ph Are there any more review comments to address?

bflad

Hi @ewbankkit 👋 Thanks for contributing this. Please see the below for some minor changes but otherwise good submission. Please reach out if you have any questions or do not have time to implement the feedback.

Since this Direct Connect resource testing requires a physical connection setup that the maintainers do not currently have access to, we can approve this pull request after the changes and two community acceptance test passing runs (one of these can be yours).

bflad · 2019-07-29T14:19:31Z

aws/resource_aws_dx_transit_virtual_interface.go

+		return err
+	}
+
+	return resourceAwsDxTransitVirtualInterfaceUpdate(d, meta)


Since CreateTransitVirtualInterface can support tag-on-create and already handles MTU appropriately above, we should prefer to call Read after Create.

Suggested change

return resourceAwsDxTransitVirtualInterfaceUpdate(d, meta)

return resourceAwsDxTransitVirtualInterfaceRead(d, meta)

bflad · 2019-07-29T14:22:31Z

aws/resource_aws_dx_transit_virtual_interface_test.go

+	return nil
+}
+
+func testAccCheckAwsDxTransitVirtualInterfaceExists(name string) resource.TestCheckFunc {


Our testAccCheck...Exists() functions should be calling the API to verify the infrastructure exists as expected -- similar but opposite to the testAccCheckAwsDxTransitVirtualInterfaceDestroy function above. 👍

I'll do the same for other DX virtual interface resources in #9572.

website/docs/r/dx_transit_virtual_interface.html.markdown

Co-Authored-By: Brian Flad <[email protected]>

…faces - hashicorp#8843.

Error: error creating Direct Connect transit virtual interface: InvalidParameter: 1 validation error(s) found. - minimum field size of 1, CreateTransitVirtualInterfaceInput.NewTransitVirtualInterface.Tags.

… allowed on a Connection'.

ewbankkit · 2019-07-30T19:05:29Z

@bflad Review comments addressed.
I also split the tagging acceptance tests from the other attribute acceptance tests which showed that the tests must be run serially, else you get the error:

error creating Direct Connect transit virtual interface: DirectConnectClientException: Only one Transit Virtual Interface is allowed on a Connection

Latest acceptance tests:

$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxTransitVirtualInterface
=== RUN   TestAccAwsDxTransitVirtualInterface/basic
=== RUN   TestAccAwsDxTransitVirtualInterface/tags
--- PASS: TestAccAwsDxTransitVirtualInterface (1626.76s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/basic (975.40s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/tags (651.36s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1626.831s

bflad · 2019-07-30T21:19:43Z

Awesome, thanks @ewbankkit. Updates look good. If another person can verify the acceptance testing also passes on their own Direct Connect connection and show the output here, we'll merge this in. 👍

ewbankkit · 2019-07-31T17:10:40Z

One last change - Setting arn can be moved to the Read method now, removing duplicated code.

=== RUN   TestAccAwsDxTransitVirtualInterface/tags
    --- PASS: TestAccAwsDxTransitVirtualInterface/tags (514.06s)

ewbankkit · 2019-08-02T21:06:56Z

Using common Exists and Destroy methods from #9572 in acceptance tests.
Acceptance tests:

$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxTransitVirtualInterface
=== RUN   TestAccAwsDxTransitVirtualInterface/basic
=== RUN   TestAccAwsDxTransitVirtualInterface/tags
--- PASS: TestAccAwsDxTransitVirtualInterface (1584.46s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/basic (942.27s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/tags (642.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1584.521s

heycasey · 2019-08-05T16:54:23Z

Is there anything I can do to help @bflad ? I saw that you were looking for another person to do acceptance testing, and I'd be happy to do that if I had documentation that describes how to do this. Ready to help to get this PR merged ASAP.

ryno75 · 2019-08-06T19:06:59Z

@bflad I ran the acceptance test with my DX Connection and it seems to work as advertised (actual dxcon redacted)...

DX_CONNECTION_ID=dxcon-bbbbbbbb make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxTransitVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxTransitVirtualInterface -timeout 120m
=== RUN   TestAccAwsDxTransitVirtualInterface
=== RUN   TestAccAwsDxTransitVirtualInterface/basic
=== RUN   TestAccAwsDxTransitVirtualInterface/tags
--- PASS: TestAccAwsDxTransitVirtualInterface (1417.41s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/basic (743.95s)
    --- PASS: TestAccAwsDxTransitVirtualInterface/tags (673.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1417.971s

bflad

Code looks good and approving on two passing community acceptance testing runs! 🚀 Thanks so much @ewbankkit and @ryno75!

ghost · 2019-08-07T17:37:55Z

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2019-11-02T14:54:05Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit mentioned this pull request May 3, 2019

Allow aws_dx_gateway_association and aws_dx_private_virtual_interface to reference Transit Gateway #8490

Closed

ewbankkit force-pushed the issue-8490.dx_transit_virtual_interface branch 2 times, most recently from 0b33c48 to 55247fb Compare May 3, 2019 20:48

ewbankkit mentioned this pull request May 3, 2019

New resources: aws_dx_hosted_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter #8523

Merged

n3ph suggested changes May 7, 2019

View reviewed changes

bflad added the new-resource Introduces a new resource. label May 9, 2019

This was referenced Jun 3, 2019

aws_dx_private_virtual_interface: 8500 MTU #8841

Closed

Ensure correct VIF type during import of Direct Connect Virtual Interfaces #8843

Closed

aeschright requested a review from a team June 26, 2019 16:57

ewbankkit mentioned this pull request Jun 27, 2019

AWS Direct Connect resources: Add support for tag-on-create #9172

Closed

8 tasks

ewbankkit and others added 2 commits July 26, 2019 14:32

Add 'aws_dx_transit_virtual_interface' resource.

6a9b932

Documentation fix after review.

68c2994

ewbankkit force-pushed the issue-8490.dx_transit_virtual_interface branch from c55e29f to 68c2994 Compare July 26, 2019 18:32

bflad reviewed Jul 29, 2019

View reviewed changes

bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 29, 2019

bflad self-assigned this Jul 29, 2019

ewbankkit and others added 6 commits July 29, 2019 13:26

Update website/docs/r/dx_transit_virtual_interface.html.markdown

0528415

Co-Authored-By: Brian Flad <[email protected]>

Code changes after review.

630edbd

Ensure correct VIF type during import of Direct Connect Virtual Inter…

085be40

…faces - hashicorp#8843.

Fix:

405b5d6

Error: error creating Direct Connect transit virtual interface: InvalidParameter: 1 validation error(s) found. - minimum field size of 1, CreateTransitVirtualInterfaceInput.NewTransitVirtualInterface.Tags.

'%#v' -> '%s' when logging request structure.

5a60769

Run acceptance tests serially: 'Only one Transit Virtual Interface is…

aee8c35

… allowed on a Connection'.

Set 'arn' in Read method. Remove duplicate code.

5a039e1

ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 31, 2019

ewbankkit mentioned this pull request Aug 2, 2019

Direct Connect virtual interfaces: Tag-on-create and validate type during import #9572

Merged

Use common 'Exists' and 'Destroy' methods - hashicorp#9572.

9763e96

bflad added this to the v2.23.0 milestone Aug 6, 2019

bflad approved these changes Aug 6, 2019

View reviewed changes

bflad merged commit 1406a50 into hashicorp:master Aug 6, 2019

bflad added a commit that referenced this pull request Aug 6, 2019

Update CHANGELOG for #8522

7ba4b39

ewbankkit deleted the issue-8490.dx_transit_virtual_interface branch August 7, 2019 11:56

ghost locked and limited conversation to collaborators Nov 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_dx_transit_virtual_interface #8522

New resource: aws_dx_transit_virtual_interface #8522

ewbankkit commented May 3, 2019 •

edited

Loading

n3ph left a comment

n3ph May 7, 2019

ewbankkit May 7, 2019

heycasey commented Jul 23, 2019

ewbankkit commented Jul 24, 2019

ewbankkit commented Jul 26, 2019

bflad left a comment

bflad Jul 29, 2019

ewbankkit Jul 29, 2019

bflad Jul 29, 2019

ewbankkit Jul 29, 2019

ewbankkit Jul 31, 2019

ewbankkit commented Jul 30, 2019

bflad commented Jul 30, 2019

ewbankkit commented Jul 31, 2019

ewbankkit commented Aug 2, 2019 •

edited

Loading

heycasey commented Aug 5, 2019

ryno75 commented Aug 6, 2019 •

edited

Loading

bflad left a comment

ghost commented Aug 7, 2019

ghost commented Nov 2, 2019

	return resourceAwsDxTransitVirtualInterfaceUpdate(d, meta)
	return resourceAwsDxTransitVirtualInterfaceRead(d, meta)

New resource: aws_dx_transit_virtual_interface #8522

New resource: aws_dx_transit_virtual_interface #8522

Conversation

ewbankkit commented May 3, 2019 • edited Loading

Community Note

n3ph left a comment

Choose a reason for hiding this comment

n3ph May 7, 2019

Choose a reason for hiding this comment

ewbankkit May 7, 2019

Choose a reason for hiding this comment

heycasey commented Jul 23, 2019

ewbankkit commented Jul 24, 2019

ewbankkit commented Jul 26, 2019

bflad left a comment

Choose a reason for hiding this comment

bflad Jul 29, 2019

Choose a reason for hiding this comment

ewbankkit Jul 29, 2019

Choose a reason for hiding this comment

bflad Jul 29, 2019

Choose a reason for hiding this comment

ewbankkit Jul 29, 2019

Choose a reason for hiding this comment

ewbankkit Jul 31, 2019

Choose a reason for hiding this comment

ewbankkit commented Jul 30, 2019

bflad commented Jul 30, 2019

ewbankkit commented Jul 31, 2019

ewbankkit commented Aug 2, 2019 • edited Loading

heycasey commented Aug 5, 2019

ryno75 commented Aug 6, 2019 • edited Loading

bflad left a comment

Choose a reason for hiding this comment

ghost commented Aug 7, 2019

ghost commented Nov 2, 2019

ewbankkit commented May 3, 2019 •

edited

Loading

ewbankkit commented Aug 2, 2019 •

edited

Loading

ryno75 commented Aug 6, 2019 •

edited

Loading