-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct Connect virtual interfaces: Tag-on-create and validate type during import #9572
Conversation
bde2982
to
6585b1a
Compare
5ca2846
to
051da6a
Compare
Removing WIP. |
Thanks for all the cleanup/refactoring here, @ewbankkit 💯 Just a note that in the future its easier for the maintainers to review the refactoring work when those are broken into their own separate commits (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ewbankkit 👋 Thanks again for this. Overall its pretty good, just a few things below.
Similar to the other Direct Connect acceptance testing that requires an active DX connection, the maintainers here do not currently have the ability to test this themselves, so this will require another community member to run and show passing testing results.
Relatedly, we would love to have a working relationship with the Direct Connect service team so we don't need to slow down this process. If you (or anyone else reading this) are willing, please reach out to your AWS account management team about talking to HashiCorp through the Amazon Partner Network. Thanks! 😄
OK, common Exists and Destroy routines added to new file $ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPrivateVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxPrivateVirtualInterface -timeout 120m
=== RUN TestAccAwsDxPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxPrivateVirtualInterface_basic
=== RUN TestAccAwsDxPrivateVirtualInterface_Tags
=== PAUSE TestAccAwsDxPrivateVirtualInterface_Tags
=== RUN TestAccAwsDxPrivateVirtualInterface_DxGateway
=== PAUSE TestAccAwsDxPrivateVirtualInterface_DxGateway
=== CONT TestAccAwsDxPrivateVirtualInterface_basic
=== CONT TestAccAwsDxPrivateVirtualInterface_Tags
=== CONT TestAccAwsDxPrivateVirtualInterface_DxGateway
--- PASS: TestAccAwsDxPrivateVirtualInterface_DxGateway (647.50s)
--- PASS: TestAccAwsDxPrivateVirtualInterface_Tags (647.89s)
--- PASS: TestAccAwsDxPrivateVirtualInterface_basic (970.00s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 970.098s
$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPrivateVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxHostedPrivateVirtualInterface -timeout 120m
=== RUN TestAccAwsDxHostedPrivateVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedPrivateVirtualInterface_basic
=== RUN TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags
=== PAUSE TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags
=== CONT TestAccAwsDxHostedPrivateVirtualInterface_basic
=== CONT TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_AccepterTags (459.81s)
--- PASS: TestAccAwsDxHostedPrivateVirtualInterface_basic (460.79s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 460.937s
$ DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxPublicVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxPublicVirtualInterface -timeout 120m
=== RUN TestAccAwsDxPublicVirtualInterface_basic
=== PAUSE TestAccAwsDxPublicVirtualInterface_basic
=== RUN TestAccAwsDxPublicVirtualInterface_Tags
=== PAUSE TestAccAwsDxPublicVirtualInterface_Tags
=== CONT TestAccAwsDxPublicVirtualInterface_basic
=== CONT TestAccAwsDxPublicVirtualInterface_Tags
--- PASS: TestAccAwsDxPublicVirtualInterface_basic (35.75s)
--- PASS: TestAccAwsDxPublicVirtualInterface_Tags (45.57s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 45.663s
$ AWS_ALTERNATE_PROFILE=pppppppp DX_CONNECTION_ID=dxcon-aaaaaaaa make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsDxHostedPublicVirtualInterface'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAwsDxHostedPublicVirtualInterface -timeout 120m
=== RUN TestAccAwsDxHostedPublicVirtualInterface_basic
=== PAUSE TestAccAwsDxHostedPublicVirtualInterface_basic
=== RUN TestAccAwsDxHostedPublicVirtualInterface_AccepterTags
=== PAUSE TestAccAwsDxHostedPublicVirtualInterface_AccepterTags
=== CONT TestAccAwsDxHostedPublicVirtualInterface_basic
=== CONT TestAccAwsDxHostedPublicVirtualInterface_AccepterTags
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_basic (50.09s)
--- PASS: TestAccAwsDxHostedPublicVirtualInterface_AccepterTags (59.12s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 59.206s |
… verify virtual interface type during import.
…rtual_interface_accepter: Add support for tag-on-create and verify virtual interface type during import.
…verify virtual interface type during import.
…ual_interface_accepter: Add support for tag-on-create and verify virtual interface type during import.
Co-Authored-By: Brian Flad <[email protected]>
b8642a6
to
2b5beae
Compare
Rebased to fix conflicts and did the Terraform Plugin SDK migration for the new source file. |
@ryno75 Will you be able to verify? |
Confirming acceptance tests:
|
@devonbleak Many thanks for the independent verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @ewbankkit the updates and @devonbleak for the testing assistance! 🚀
Approving per our community testing strategy for Direct Connect resources after code review. 👍
This has been released in version 2.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #8843.
Relates #9172.
Release note for CHANGELOG:
Output from acceptance testing: