Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Direct Connect resources: Add support for tag-on-create #9172

Closed
8 tasks done
ewbankkit opened this issue Jun 27, 2019 · 6 comments · Fixed by #11330
Closed
8 tasks done

AWS Direct Connect resources: Add support for tag-on-create #9172

ewbankkit opened this issue Jun 27, 2019 · 6 comments · Fixed by #11330
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jun 27, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support for tagging AWS Direct Connect resources on creation added in AWS SDK v1.20.11:

Tags will now be included in the API responses of all supported resources (Virtual interfaces, Connections, Interconnects and LAGs). You can also add tags while creating these resources.

New or Affected Resource(s)

References

Related:

Requires:

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 27, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 27, 2019
@bflad bflad added service/directconnect Issues and PRs that pertain to the directconnect service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 27, 2019
@ewbankkit
Copy link
Contributor Author

Announcement.

@ewbankkit
Copy link
Contributor Author

Tag-on-create support for aws_dx_transit_virtual_interface and aws_dx_hosted_transit_virtual_interface_accepter implemented in #8522 and #8523 respectively.

@ewbankkit
Copy link
Contributor Author

This will allow us to replace calls to resourceAwsDxXXXUpdate from resourceAwsDxXXXCreate with calls to resourceAwsDxXXXRead, the preferred pattern.

@bflad
Copy link
Contributor

bflad commented Dec 18, 2019

The final resources here, aws_dx_connection and aws_dx_lag have been updated with this support and will release with version 2.43.0 of the Terraform AWS Provider, tomorrow. Thanks @ewbankkit!

@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Projects
None yet
2 participants