Allow a node pool to be created before it is destroyed #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asproul
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
reviewed
Sep 5, 2019
added 4 commits
September 5, 2019 09:45
aaron-lane
added
enhancement
|
PTAL @morgante |
morgante
suggested changes
Sep 9, 2019
morgante
reviewed
Sep 10, 2019
morgante
suggested changes
Sep 11, 2019
|
PTAL @morgante |
Added two examples and one test fixture. |
|
PTAL @morgante |
morgante
approved these changes
Oct 11, 2019
|
Thanks for the contribution! |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…efore-destroy-nodepools Allow a node pool to be created before it is destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is inspired by hashicorp/terraform-provider-google#1054 (comment) .
Currently, if a node pool has to be recreated for any number of reasons, the node pool is deleted then, created. This can be a problem if it is the only node pool in the gke cluster and the new node pool cannot be provisioned. In this scenario, pods could not be scheduled.
This change allows a node pool to be created before it is deleted so that any issues with node pool creation and/or provisioning are discovered before the node pool is removed. This feature is controlled by the variable
node_pools_create_before_destroy. In order to avoid node pool name collisions, a 4 character alphanumeric is added as a suffix to the name.